Re: [PATCH net-next v2 2/9] net: macsec: move some definitions in a dedicated header

Antoine Tenart
2019-08-12T08:17:36Z

Hi Igor,

On Sat, Aug 10, 2019 at 12:19:36PM +0000, Igor Russkikh wrote:
> > +/**
> > + * struct macsec_tx_sa - transmit secure association
> > + * @active:
> > + * @next_pn: packet number to use for the next packet
> > + * @lock: protects next_pn manipulations
> > + * @key: key structure
> > + * @stats: per-SA stats
> > + */
> > +struct macsec_tx_sa {
> > + struct macsec_key key;
> > + spinlock_t lock;
> > + u32 next_pn;
> > + refcount_t refcnt;
> > + bool active;
> > + bool offloaded;
>
> I don't see this `offloaded` field being used anywhere. Is this needed?

You're right it's not and was only used in previous versions of this
patchset. I'll remove it.

Thanks for spotting this!
Antoine

--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering