From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 2/2] irqchip/tegra: Clean up coding style
Date: Sun, 11 Aug 2019 21:30:44 +0300 [thread overview]
Message-ID: <20190811183044.13925-2-digetx@gmail.com> (raw)
In-Reply-To: <20190811183044.13925-1-digetx@gmail.com>
Make coding style to conform to the kernel's standard by fixing checkpatch
warnings about "line over 80 characters".
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/irqchip/irq-tegra.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index 14dcacc2ad38..f829a5990dae 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -74,7 +74,7 @@ static struct tegra_ictlr_info *lic;
static inline void tegra_ictlr_write_mask(struct irq_data *d, unsigned long reg)
{
- void __iomem *base = (void __iomem __force *)d->chip_data;
+ void __iomem *base = lic->base[d->hwirq / 32];
u32 mask;
mask = BIT(d->hwirq % 32);
@@ -142,7 +142,8 @@ static int tegra_ictlr_suspend(void)
writel_relaxed(~0ul, ictlr + ICTLR_CPU_IER_CLR);
/* Enable the wakeup sources of ictlr */
- writel_relaxed(lic->ictlr_wake_mask[i], ictlr + ICTLR_CPU_IER_SET);
+ writel_relaxed(lic->ictlr_wake_mask[i],
+ ictlr + ICTLR_CPU_IER_SET);
}
local_irq_restore(flags);
@@ -222,7 +223,6 @@ static int tegra_ictlr_domain_alloc(struct irq_domain *domain,
{
struct irq_fwspec *fwspec = data;
struct irq_fwspec parent_fwspec;
- struct tegra_ictlr_info *info = domain->host_data;
irq_hw_number_t hwirq;
unsigned int i;
@@ -235,13 +235,9 @@ static int tegra_ictlr_domain_alloc(struct irq_domain *domain,
if (hwirq >= (num_ictlrs * 32))
return -EINVAL;
- for (i = 0; i < nr_irqs; i++) {
- int ictlr = (hwirq + i) / 32;
-
+ for (i = 0; i < nr_irqs; i++)
irq_domain_set_hwirq_and_chip(domain, virq + i, hwirq + i,
- &tegra_ictlr_chip,
- (void __force *)info->base[ictlr]);
- }
+ &tegra_ictlr_chip, NULL);
parent_fwspec = *fwspec;
parent_fwspec.fwnode = domain->parent->fwnode;
@@ -312,7 +308,6 @@ static int __init tegra_ictlr_init(struct device_node *node,
"%pOF: Found %u interrupt controllers in DT; expected %u.\n",
node, num_ictlrs, soc->num_ictlrs);
-
domain = irq_domain_add_hierarchy(parent_domain, 0, num_ictlrs * 32,
node, &tegra_ictlr_domain_ops,
lic);
--
2.22.0
next prev parent reply other threads:[~2019-08-11 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-11 18:30 [PATCH v1 1/2] irqchip/tegra: Remove everything related to COP Dmitry Osipenko
2019-08-11 18:30 ` Dmitry Osipenko [this message]
2019-08-13 14:50 ` [PATCH v1 2/2] irqchip/tegra: Clean up coding style Marc Zyngier
2019-08-13 15:40 ` Dmitry Osipenko
2019-08-13 16:18 ` Marc Zyngier
2019-08-13 16:59 ` Dmitry Osipenko
2019-08-13 14:25 ` [PATCH v1 1/2] irqchip/tegra: Remove everything related to COP Marc Zyngier
2019-08-13 15:09 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190811183044.13925-2-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=jason@lakedaemon.net \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox