From: Christoph Hellwig <hch@lst.de>
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] ia64: annotate switch fallthroughs in ia64_handle_unaligned
Date: Mon, 12 Aug 2019 08:55:22 +0200 [thread overview]
Message-ID: <20190812065524.19959-3-hch@lst.de> (raw)
In-Reply-To: <20190812065524.19959-1-hch@lst.de>
Replace the "no break" comments with something that the compiler
recognizes.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
arch/ia64/kernel/unaligned.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/ia64/kernel/unaligned.c b/arch/ia64/kernel/unaligned.c
index eb7d5df59fa3..2d4e65ba5c3e 100644
--- a/arch/ia64/kernel/unaligned.c
+++ b/arch/ia64/kernel/unaligned.c
@@ -1431,7 +1431,7 @@ ia64_handle_unaligned (unsigned long ifa, struct pt_regs *regs)
if (u.insn.x)
/* oops, really a semaphore op (cmpxchg, etc) */
goto failure;
- /* no break */
+ /*FALLTHRU*/
case LDS_IMM_OP:
case LDSA_IMM_OP:
case LDFS_OP:
@@ -1459,7 +1459,7 @@ ia64_handle_unaligned (unsigned long ifa, struct pt_regs *regs)
if (u.insn.x)
/* oops, really a semaphore op (cmpxchg, etc) */
goto failure;
- /* no break */
+ /*FALLTHRU*/
case LD_IMM_OP:
case LDA_IMM_OP:
case LDBIAS_IMM_OP:
@@ -1475,7 +1475,7 @@ ia64_handle_unaligned (unsigned long ifa, struct pt_regs *regs)
if (u.insn.x)
/* oops, really a semaphore op (cmpxchg, etc) */
goto failure;
- /* no break */
+ /*FALLTHRU*/
case ST_IMM_OP:
case STREL_IMM_OP:
ret = emulate_store_int(ifa, u.insn, regs);
--
2.20.1
next prev parent reply other threads:[~2019-08-12 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 6:55 fix misc compiler warnings in the ia64 build Christoph Hellwig
2019-08-12 6:55 ` [PATCH 1/4] ia64: annotate a switch fallthrough in ia64_do_signal Christoph Hellwig
2019-08-12 6:55 ` Christoph Hellwig [this message]
2019-08-12 6:55 ` [PATCH 3/4] ia64/kprobes: remove the unused ia64_get_bsp_cfm function Christoph Hellwig
2019-08-12 6:55 ` [PATCH 4/4] kernel: only define task_struct_whitelist conditionally Christoph Hellwig
2019-08-12 21:47 ` fix misc compiler warnings in the ia64 build Luck, Tony
2019-08-12 21:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812065524.19959-3-hch@lst.de \
--to=hch@lst.de \
--cc=fenghua.yu@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox