Re: [PATCH] mfd: omap-usb-host: Mark expected switch fall-throughs

Lee Jones
2019-08-12T08:14:54Z

On Sun, 28 Jul 2019, Gustavo A. R. Silva wrote:

> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_resume':
> drivers/mfd/omap-usb-host.c:303:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (!IS_ERR(omap->hsic480m_clk[i])) {
> ^
> drivers/mfd/omap-usb-host.c:313:3: note: here
> case OMAP_EHCI_PORT_MODE_TLL:
> ^~~~
> drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_suspend':
> drivers/mfd/omap-usb-host.c:345:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (!IS_ERR(omap->hsic480m_clk[i]))
> ^
> drivers/mfd/omap-usb-host.c:349:3: note: here
> case OMAP_EHCI_PORT_MODE_TLL:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/mfd/omap-usb-host.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog