From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1EA3C433FF for ; Tue, 13 Aug 2019 09:27:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7175720673 for ; Tue, 13 Aug 2019 09:27:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=android.com header.i=@android.com header.b="jCWRzcaG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728041AbfHMJ1c (ORCPT ); Tue, 13 Aug 2019 05:27:32 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55290 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727975AbfHMJ1c (ORCPT ); Tue, 13 Aug 2019 05:27:32 -0400 Received: by mail-wm1-f67.google.com with SMTP id p74so828960wme.4 for ; Tue, 13 Aug 2019 02:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Qb/NP/52zEK5PNxPMnXLw+XaNrKng1Uv0nlxkfu6WDI=; b=jCWRzcaGkDKOkrHs54r/2Iwg1e7W2380CPMiJi3sIolpj8Szd6M59k2esnkxI+sR01 sHe23sej4qoNNPAW/Cns0W2WXN+7lgQz5L5NKNKd/tFlsxNmcSs5k9mUwDsBDhzpDpn8 lkpbdtZ80wmpdVvEXANg/rvduif+7iGEl7oXeKjMmQ1hc6m2dUNb+fsM51r87O06q0Dv YLaubrEXEMPNYregryyPwutcqOY2OupwHEIjpWNgASYukqLiriFti7GNwVT2bN1TUw3X mlBXGvRO4pwB2qkmvGqapzD4ikfsJDO+T1d+34kKmf3tSuIO60qx+rH1D1gr2nC4DdTQ sbew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Qb/NP/52zEK5PNxPMnXLw+XaNrKng1Uv0nlxkfu6WDI=; b=k9MdxYxdmeWpyOPtYa4QBFk9YhuIhjZg9ZJ6dA65F4eyjD49snhC/+SuBBQpT/upZP 1RXgRF79fRDhp0v7gDk8FL7nQL/LfOB/1AOQLp6ObM7oPgByp7NpsndRzN6POkAkH69T M6UBPgxrCmM61bjRz9hppd3IMsVTpnN/hE4X7K7V1Y4kuwMSL8OLs71Q1j9d7mNjnQLu lZyGDiwm1JqH6EpbnJZCV14ZKHYIEaGs1DBQRdZV5SfYQcX+mRzq+Am3EgiiUY/OY7sd W7KPvTNhXUey1LOrHRJkMA4n1LsqTl+kF+5pfaRPYu1K+1AEWJsT4oyA8wUk3pNsvBUo QOoQ== X-Gm-Message-State: APjAAAUwUC0wa0Gfycy1unksIjP7IiTHiPjEP4lWRpIOdE6kKTN1pwXC cf/H5VJCvc1Ai3BQfrT0ljIYOg== X-Google-Smtp-Source: APXvYqzLotVVunbMioY5PLRWqpTro+w0pf/dFhcJ71pCniUVebL9qaV6BQcV2U40becIcQa9c0ELGw== X-Received: by 2002:a1c:6641:: with SMTP id a62mr1927540wmc.175.1565688450282; Tue, 13 Aug 2019 02:27:30 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e751:37a0:1e95:e65d]) by smtp.gmail.com with ESMTPSA id x20sm235928251wrg.10.2019.08.13.02.27.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 13 Aug 2019 02:27:29 -0700 (PDT) Date: Tue, 13 Aug 2019 10:27:28 +0100 From: Alessio Balsini To: Greg KH Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Jason Gunthorpe , Leon Romanovsky , "hange-folder>?" Subject: Re: [PATCH 4.9.y 4.14.y] IB/mlx5: Fix leaking stack memory to userspace Message-ID: <20190812160714.GA246269@google.com> References: <20190812105136.151840-1-balsini@android.com> <20190812105503.153253-1-balsini@android.com> <20190812142316.GA12869@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190812142316.GA12869@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oops, you are totally right, I was still looking at the latest mlx5_ib_create_qp_resp struct while backporting these patches :) Sorry for that, Alessio On Mon, Aug 12, 2019 at 04:23:16PM +0200, Greg KH wrote: > On Mon, Aug 12, 2019 at 11:55:03AM +0100, Alessio Balsini wrote: > > From: Jason Gunthorpe > > > > commit 0625b4ba1a5d4703c7fb01c497bd6c156908af00 upstream. > > > > mlx5_ib_create_qp_resp was never initialized and only the first 4 bytes > > were written. > > > > Fixes: 41d902cb7c32 ("RDMA/mlx5: Fix definition of mlx5_ib_create_qp_resp") > > This commit only showed up in the following kernel releases: > 4.17 4.18.7 4.19 > > so why is this "fix" commit needed in anything older than 4.17? > > That's why I did not backport it to older kernels, as I do not think it > is needed there. Do you? > > thanks, > > greg k-h