From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BFD1C31E40 for ; Mon, 12 Aug 2019 20:36:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05BC72070C for ; Mon, 12 Aug 2019 20:36:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbfHLUgN (ORCPT ); Mon, 12 Aug 2019 16:36:13 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:37696 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726527AbfHLUgM (ORCPT ); Mon, 12 Aug 2019 16:36:12 -0400 Received: from callcc.thunk.org (guestnat-104-133-9-109.corp.google.com [104.133.9.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x7CKa5qs030319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Aug 2019 16:36:07 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 6715F4218EF; Mon, 12 Aug 2019 16:36:05 -0400 (EDT) Date: Mon, 12 Aug 2019 16:36:05 -0400 From: "Theodore Y. Ts'o" To: Colin King Cc: Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: set error return correctly when ext4_htree_store_dirent fails Message-ID: <20190812203605.GC28705@mit.edu> Mail-Followup-To: "Theodore Y. Ts'o" , Colin King , Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190805224419.24639-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190805224419.24639-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 05, 2019 at 11:44:19PM +0100, Colin King wrote: > From: Colin Ian King > > Currently when the call to ext4_htree_store_dirent fails the error return > variable 'ret' is is not being set to the error code and variable count is > instead, hence the error code is not being returned. Fix this by assigning > ret to the error return code. > > Addresses-Coverity: ("Unused value") > Fixes: 8af0f0822797 ("ext4: fix readdir error in the case of inline_data+dir_index") > Signed-off-by: Colin Ian King Applied, thanks. - Ted