Re: [PATCH 5/5] ARM: dts: armada385-wd-mcex2u: Add DTS file for WD My Cloud EX2 Ultra

Andrew Lunn
2019-07-23T13:48:26Z

> + internal-regs {
> + timer@c200 {
> + status = "disabled";
> + };
> +
> + i2c0: i2c@11000 {
> + status = "okay";
> + clock-frequency = <100000>;
> + };
> +
> + i2c1: i2c@11100 {
> + status = "okay";
> + clock-frequency = <100000>;
> + };

It is a bit unusual to enable i2c busses when there is nothing on
them.

> + ethernet@34000 {
> + phy = <&phy0>;

phy has been deprecated. Please use phy-handle.

Andrew