Re: [PATCH v12 12/18] kunit: test: add tests for KUnit managed resources

Stephen Boyd
2019-08-13T04:31:44Z

Quoting Brendan Higgins (2019-08-12 11:24:15)
> +
> +static int kunit_resource_test_init(struct kunit *test)
> +{
> + struct kunit_test_resource_context *ctx =
> + kzalloc(sizeof(*ctx), GFP_KERNEL);
> +
> + if (!ctx)
> + return -ENOMEM;

Should this use the test assertion logic to make sure that it's not
failing allocations during init? BTW, maybe kunit allocation APIs should
fail the test if they fail to allocate in general. Unless we're unit
testing failure to allocate problems.

> +
> + test->priv = ctx;
> +
> + kunit_init_test(&ctx->test, "test_test_context");
> +
> + return 0;