From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C40BC433FF for ; Tue, 13 Aug 2019 10:26:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 078E220679 for ; Tue, 13 Aug 2019 10:26:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728801AbfHMK0M (ORCPT ); Tue, 13 Aug 2019 06:26:12 -0400 Received: from muru.com ([72.249.23.125]:57106 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727416AbfHMK0L (ORCPT ); Tue, 13 Aug 2019 06:26:11 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5C791805C; Tue, 13 Aug 2019 10:26:39 +0000 (UTC) Date: Tue, 13 Aug 2019 03:26:08 -0700 From: Tony Lindgren To: Janusz Krzysztofik Cc: Aaro Koskinen , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH for v5.3] ARM: OMAP1: ams-delta-fiq: Fix missing irq_ack Message-ID: <20190813102608.GK52127@atomide.com> References: <20190811084802.630-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190811084802.630-1-jmkrzyszt@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Janusz Krzysztofik [190811 01:48]: > Non-serio path of Amstrad Delta FIQ deferred handler depended on > irq_ack() method provided by OMAP GPIO driver. That method has been > removed by commit 693de831c6e5 ("gpio: omap: remove irq_ack method"). > Remove useless code from the deferred handler and reimplement the > missing operation inside the base FIQ handler. > > Should another dependency - irq_unmask() - be ever removed from the OMAP > GPIO driver, WARN once if missing. Thanks applying into fixes. Tony