From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8459FC433FF for ; Tue, 13 Aug 2019 10:59:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63570206C2 for ; Tue, 13 Aug 2019 10:59:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728488AbfHMK7z (ORCPT ); Tue, 13 Aug 2019 06:59:55 -0400 Received: from muru.com ([72.249.23.125]:57152 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728120AbfHMK7y (ORCPT ); Tue, 13 Aug 2019 06:59:54 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 475D6805C; Tue, 13 Aug 2019 11:00:22 +0000 (UTC) Date: Tue, 13 Aug 2019 03:59:51 -0700 From: Tony Lindgren To: Suman Anna Cc: Tero Kristo , Roger Quadros , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] bus: ti-sysc: Simplify cleanup upon failures in sysc_probe() Message-ID: <20190813105951.GN52127@atomide.com> References: <20190625233315.22301-1-s-anna@ti.com> <20190625233315.22301-6-s-anna@ti.com> <20190627121158.GJ5447@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Suman Anna [190627 15:24]: > On 6/27/19 7:11 AM, Tony Lindgren wrote: > > Hi, > > > > * Suman Anna [190625 23:33]: > >> The clocks are not yet parsed and prepared until after a successful > >> sysc_get_clocks(), so there is no need to unprepare the clocks upon > >> any failure of any of the prior functions in sysc_probe(). The current > >> code path would have been a no-op because of the clock validity checks > >> within sysc_unprepare(), but let's just simplify the cleanup path by > >> returning the error directly. > >> > >> While at this, also fix the cleanup path for a sysc_init_resets() > >> failure which is executed after the clocks are prepared. > > > > Sounds like this should get queued separately as a fix for v5.3-rc > > cycle, probably got broken with the recent ti-sysc init order changes. > > Yeah, this patch does not depend on the previous 4 patches, so can be > picked up independently for v5.3-rc as well. OK applying the $subject patch into fixes, and the rest into omap-for-v5.4/ti-sysc. Regards, Tony