From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE00EC433FF for ; Tue, 13 Aug 2019 11:29:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFCEE20673 for ; Tue, 13 Aug 2019 11:29:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727035AbfHML3f (ORCPT ); Tue, 13 Aug 2019 07:29:35 -0400 Received: from muru.com ([72.249.23.125]:57164 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726650AbfHML3f (ORCPT ); Tue, 13 Aug 2019 07:29:35 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 00CBA805C; Tue, 13 Aug 2019 11:30:00 +0000 (UTC) Date: Tue, 13 Aug 2019 04:29:30 -0700 From: Tony Lindgren To: Jyri Sarha Cc: Suman Anna , linux-omap@vger.kernel.org, Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Keerthy , Nishanth Menon , Peter Ujfalusi , Roger Quadros , Tero Kristo , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc Message-ID: <20190813112930.GO52127@atomide.com> References: <20190723112811.44381-1-tony@atomide.com> <20190723112811.44381-3-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jyri Sarha [190813 11:05]: > On 23/07/2019 22:03, Suman Anna wrote: > > + Jyri > > > > On 7/23/19 6:28 AM, Tony Lindgren wrote: > >> We currently get a warning for lcdc because of a difference > >> with dts provided configuration compared to the legacy platform > >> data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in > >> the platform data without configuring the modes. > > > > Hi Tony, > > While I understand that you are trying to match the DT data with the > > existing legacy data, do you know if there was a reason why this was > > omitted in the first place? Should we be really adding the MSTANDBY_ > > flags and fix up the DTS node accordingly? I tried looking through the > > git log, and the initial commit itself didn't add the MSTANDBY_ flags > > but used the SYSC_HAS_MIDLEMODE. > > > > Jyri, > > Do you know the history? > > > > Sorry. This all has happened before my time. This is all new to me. Oh OK. Well if possible, could you please check if the following patch behaves with v5.2 for you for LCDC? I only have rack access to a beaglebone with hdmi right now. TRM "Table 13-34. SYSCONFIG Register Field Descriptions" lists both standbymode and idlemode that should be just the sidle and midle registers where midle is currently unconfigured. Regards, Tony 8< --------------------- diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c @@ -255,8 +255,9 @@ static struct omap_hwmod am33xx_gpio0_hwmod = { static struct omap_hwmod_class_sysconfig lcdc_sysc = { .rev_offs = 0x0, .sysc_offs = 0x54, - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), - .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), + .sysc_flags = SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE, + .idlemodes = SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | + MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART, .sysc_fields = &omap_hwmod_sysc_type2, };