From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Nishka Dasgupta <nishkadg.linux@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] bus: ti-sysc: sysc_check_children(): Change return type to void
Date: Tue, 13 Aug 2019 04:42:56 -0700 [thread overview]
Message-ID: <20190813114256.GR52127@atomide.com> (raw)
In-Reply-To: <dd6f47c8-13bc-f20e-90ce-208bd10c3bc0@ti.com>
* Roger Quadros <rogerq@ti.com> [190813 11:14]:
>
> On 13/08/2019 10:55, Nishka Dasgupta wrote:
> > Change return type of function sysc_check_children() from int to void as
> > it always returns 0. Remove its return statement as well.
> > At call site, remove the variable that was used to store the return
> > value, as well as the check on the return value.
> >
>
> You don't need to describe each and everything as it is obvious
> from code. How about?
> "Change return type of sysc_check_children() to "void"
> as it never returns error"
>
> Should both patches can be squashed into one patch?
Sure why not, makes it easier to follow :)
Regards,
Tony
next prev parent reply other threads:[~2019-08-13 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 7:17 [PATCH v2] bus: ti-sysc: sysc_check_one_child(): Change return type to void Nishka Dasgupta
2019-08-13 7:28 ` Roger Quadros
2019-08-13 7:37 ` Nishka Dasgupta
2019-08-13 7:43 ` Roger Quadros
2019-08-13 7:55 ` [PATCH v3 1/2] " Nishka Dasgupta
2019-08-13 7:55 ` [PATCH v3 2/2] bus: ti-sysc: sysc_check_children(): " Nishka Dasgupta
2019-08-13 11:13 ` Roger Quadros
2019-08-13 11:42 ` Tony Lindgren [this message]
2019-08-15 5:46 ` [PATCH v4] bus: ti-sysc: Change return types of functions Nishka Dasgupta
2019-08-15 13:02 ` Roger Quadros
2019-08-26 15:31 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813114256.GR52127@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).