From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A62AC433FF for ; Wed, 14 Aug 2019 02:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 140DE20842 for ; Wed, 14 Aug 2019 02:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565749236; bh=PuljAEhBPDf3cX1EahO0AsnnzVxQ6ib/+w6tf+J9iQ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Un9XBSlzbNJF85UcCPIKBaYKdnwJ9YCqMz4u/w9julKXBvWRQtqMG6FKR8MLW4YWG Y0CrSD3q3Txi+fF2ir2t0rKbI769LyD5R6JgIcSMZFohTc9z+qXit13MRoNFep1eP0 8iAqsRP8ylZl2CsZejai1jA8k6tPhkSTXYrGum2Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728772AbfHNCUf (ORCPT ); Tue, 13 Aug 2019 22:20:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:50322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729720AbfHNCT1 (ORCPT ); Tue, 13 Aug 2019 22:19:27 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D4CB214DA; Wed, 14 Aug 2019 02:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565749167; bh=PuljAEhBPDf3cX1EahO0AsnnzVxQ6ib/+w6tf+J9iQ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wid0OhtmIMCTYvAYkMy4uA44mtH9H8jvIY+fCMW+dU33wzuJRRijagSQeXIji7CBN HVa5KcDkvxFMNQK1wKhhd6FU6kxA675DdL/S/YaAbZH90UaIb3bTpzQ/wSy4S6zayw PxxrwbmevRMBI+gI3FRSq3hX1GkjmwBbLiLZtEFs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Oliver Neukum , syzbot+5efc10c005014d061a74@syzkaller.appspotmail.com, Dmitry Torokhov , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 32/44] Input: iforce - add sanity checks Date: Tue, 13 Aug 2019 22:18:21 -0400 Message-Id: <20190814021834.16662-32-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190814021834.16662-1-sashal@kernel.org> References: <20190814021834.16662-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum [ Upstream commit 849f5ae3a513c550cad741c68dd3d7eb2bcc2a2c ] The endpoint type should also be checked before a device is accepted. Reported-by: syzbot+5efc10c005014d061a74@syzkaller.appspotmail.com Signed-off-by: Oliver Neukum Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/joystick/iforce/iforce-usb.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/input/joystick/iforce/iforce-usb.c b/drivers/input/joystick/iforce/iforce-usb.c index e8724f1a4a251..f1d4d543d9456 100644 --- a/drivers/input/joystick/iforce/iforce-usb.c +++ b/drivers/input/joystick/iforce/iforce-usb.c @@ -145,7 +145,12 @@ static int iforce_usb_probe(struct usb_interface *intf, return -ENODEV; epirq = &interface->endpoint[0].desc; + if (!usb_endpoint_is_int_in(epirq)) + return -ENODEV; + epout = &interface->endpoint[1].desc; + if (!usb_endpoint_is_int_out(epout)) + return -ENODEV; if (!(iforce = kzalloc(sizeof(struct iforce) + 32, GFP_KERNEL))) goto fail; -- 2.20.1