From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C97EFC32750 for ; Wed, 14 Aug 2019 02:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97ADB20842 for ; Wed, 14 Aug 2019 02:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565749565; bh=udv1lL1kma3t9zZhkeiGxc80kuT7XqqSw/Pw50Vkm3I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MJnDbcZgsiVIOoJxAIirfV+3HmyGNxfctTc9hzUzWv529jsYiofAIOsO1ntRSCgzm Ds9E/tkUVEcK/iYXe3SuT3wvaVBnFYHQ19LLY/IKTyZyNlHOSo8pV5ZWEIlqa7G5lf PEca26glESGypH4FVbx7Kjfw1QS8DX6wIrDFwae0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730040AbfHNC0E (ORCPT ); Tue, 13 Aug 2019 22:26:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:54130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729822AbfHNCZ7 (ORCPT ); Tue, 13 Aug 2019 22:25:59 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF6CC20874; Wed, 14 Aug 2019 02:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565749558; bh=udv1lL1kma3t9zZhkeiGxc80kuT7XqqSw/Pw50Vkm3I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PHfyPvom7RkN21r+JvNkJ4a7QZvW2hcrUccvQb8FRahBBDHZlpin+5rKPWDZBnMgP USGZoQjJJzQGHqUfR5ZzHD0MqMyBZ92aY2xoatOOYkgJW/2yVBnc7ku2ynO5jpAKaX ifmjaOdH5vGGCw75sqX528p/Pt3U7F729gxz9e90= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Rasmus Villemoes , Willem de Bruijn , Marc Kleine-Budde , Sasha Levin , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 05/28] can: dev: call netif_carrier_off() in register_candev() Date: Tue, 13 Aug 2019 22:25:27 -0400 Message-Id: <20190814022550.17463-5-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190814022550.17463-1-sashal@kernel.org> References: <20190814022550.17463-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes [ Upstream commit c63845609c4700488e5eacd6ab4d06d5d420e5ef ] CONFIG_CAN_LEDS is deprecated. When trying to use the generic netdev trigger as suggested, there's a small inconsistency with the link property: The LED is on initially, stays on when the device is brought up, and then turns off (as expected) when the device is brought down. Make sure the LED always reflects the state of the CAN device. Signed-off-by: Rasmus Villemoes Acked-by: Willem de Bruijn Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- drivers/net/can/dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index 8b7c6425b681d..9dd968ee792e0 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -1065,6 +1065,8 @@ static struct rtnl_link_ops can_link_ops __read_mostly = { int register_candev(struct net_device *dev) { dev->rtnl_link_ops = &can_link_ops; + netif_carrier_off(dev); + return register_netdev(dev); } EXPORT_SYMBOL_GPL(register_candev); -- 2.20.1