From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0939FC32753 for ; Wed, 14 Aug 2019 13:40:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1AB7206C2 for ; Wed, 14 Aug 2019 13:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727959AbfHNNkL (ORCPT ); Wed, 14 Aug 2019 09:40:11 -0400 Received: from muru.com ([72.249.23.125]:57752 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726722AbfHNNkK (ORCPT ); Wed, 14 Aug 2019 09:40:10 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D37C680C8; Wed, 14 Aug 2019 13:40:36 +0000 (UTC) Date: Wed, 14 Aug 2019 06:40:06 -0700 From: Tony Lindgren To: Arnd Bergmann Cc: Aaro Koskinen , Dominik Brodowski , linux-omap , Linux ARM , Greg Kroah-Hartman , Linus Walleij , Bartlomiej Zolnierkiewicz , Tomi Valkeinen , Linux Kernel Mailing List Subject: Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf Message-ID: <20190814134006.GE52127@atomide.com> References: <20190808212234.2213262-1-arnd@arndb.de> <20190808212234.2213262-15-arnd@arndb.de> <20190813103605.GL52127@atomide.com> <20190813181158.GA26798@darkstar.musicnaut.iki.fi> <20190814074918.GA52127@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnd Bergmann [190814 10:37]: > On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > > * Arnd Bergmann [190813 19:34]: > > > On Tue, Aug 13, 2019 at 8:12 PM Aaro Koskinen wrote: > > > diff --git a/arch/arm/mach-omap1/hardware.h b/arch/arm/mach-omap1/hardware.h > > > index 232b8deef907..9fc76a3c9e57 100644 > > > --- a/arch/arm/mach-omap1/hardware.h > > > +++ b/arch/arm/mach-omap1/hardware.h > > > @@ -61,7 +61,7 @@ static inline u32 omap_cs3_phys(void) > > > > > > #endif /* ifndef __ASSEMBLER__ */ > > > > > > -#define OMAP1_IO_OFFSET 0x01000000 /* Virtual IO > > > = 0xfefb0000 */ > > > +#define OMAP1_IO_OFFSET 0x00fb0000 /* Virtual IO > > > = 0xff000000 */ > > > #define OMAP1_IO_ADDRESS(pa) IOMEM((pa) - OMAP1_IO_OFFSET) > > > > > > #include "serial.h" > > > > Oh OK yeah sounds like that's the issue. > > > > > There may be additional locations that hardcode the virtual address. > > > > Those should be in mach-omap1/io.c, and I recall innovator had some > > hardcoded fpga address that should also be checked. > > I see four boards with hardcoded I/O addresses, but they are all below > the PCI I/O virtual address range, and are not affected by that change. > > For the innovator FPGA access, this was ok, it uses the correct address > in the OMAP1_IO_OFFSET range. OK thanks for checking. I tried to apply your virtual address patch to test boot it, but could not get it to apply. What tree is it against? Regards, Tony