From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CDB2C32753 for ; Wed, 14 Aug 2019 17:15:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC4E82173E for ; Wed, 14 Aug 2019 17:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802918; bh=rEz9Q5kVtaIl+plmnxqQyi9B4XJzmRk64BEqAW4tO4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MzSYvO49DrtP7nOHINCnm8Va0E5gMIAfnNWvbpPMjgsPa3GaJNjmwcEKipx6J2XfR PQsjZssm//kl9XsZ5t/rkDdcyA9SuIhEdMMWA0cA7e89HE9DmNbYM48ovcAloLcvSI jcHbabgHQ9O/upOiMu2JsHvTX3me51JWskEOJngM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731208AbfHNRPQ (ORCPT ); Wed, 14 Aug 2019 13:15:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:39810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731194AbfHNRPN (ORCPT ); Wed, 14 Aug 2019 13:15:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B8A442173B; Wed, 14 Aug 2019 17:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802913; bh=rEz9Q5kVtaIl+plmnxqQyi9B4XJzmRk64BEqAW4tO4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=my7qgmR8HAUGnnHVi9+w6kMs81dbk3TPpepIcHQVh781ohZUuNcgHhtB9hg+d4SOF P6Ynnwfmk3/rMkBjHrTY+3SHOyJTZI3pyKiYrB2GUZ3/IEHvhm+bG1fgemkZyCDZB+ QHaVOOvHPK1/DfgrEYK2jzm/pbSKNM6jZgr7NQWw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , Sasha Levin Subject: [PATCH 4.14 48/69] test_firmware: fix a memory leak bug Date: Wed, 14 Aug 2019 19:01:46 +0200 Message-Id: <20190814165748.759432986@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190814165744.822314328@linuxfoundation.org> References: <20190814165744.822314328@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit d4fddac5a51c378c5d3e68658816c37132611e1f ] In test_firmware_init(), the buffer pointed to by the global pointer 'test_fw_config' is allocated through kzalloc(). Then, the buffer is initialized in __test_firmware_config_init(). In the case that the initialization fails, the following execution in test_firmware_init() needs to be terminated with an error code returned to indicate this failure. However, the allocated buffer is not freed on this execution path, leading to a memory leak bug. To fix the above issue, free the allocated buffer before returning from test_firmware_init(). Signed-off-by: Wenwen Wang Link: https://lore.kernel.org/r/1563084696-6865-1-git-send-email-wang6495@umn.edu Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- lib/test_firmware.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/test_firmware.c b/lib/test_firmware.c index f978aebe60c5b..2e5e18bbfd28e 100644 --- a/lib/test_firmware.c +++ b/lib/test_firmware.c @@ -895,8 +895,11 @@ static int __init test_firmware_init(void) return -ENOMEM; rc = __test_firmware_config_init(); - if (rc) + if (rc) { + kfree(test_fw_config); + pr_err("could not init firmware test config: %d\n", rc); return rc; + } rc = misc_register(&test_fw_misc_device); if (rc) { -- 2.20.1