From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE25C433FF for ; Wed, 14 Aug 2019 20:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 501AD21721 for ; Wed, 14 Aug 2019 20:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565813465; bh=0ZO2bzItS8h05Zv5Dud3NuHPbhZ5PtWN4ASPygX9eYM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VYX5VIcANaY3LfR+MhOUcx8UU0g5qSynIiUDdmQ4m32gEEYdjYhwXrCCoTjCw9fOd tPseaRVo1+lHayoU+7kUgKD+Fkts10aAUoyyg61/sKbBTQ3lpEwZd33tALuyzMB76a f3qp2dSkE+V/JE+wlPT64dcm9gEtk4kRkM91X4S0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729012AbfHNULD (ORCPT ); Wed, 14 Aug 2019 16:11:03 -0400 Received: from mga06.intel.com ([134.134.136.31]:60128 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728348AbfHNULD (ORCPT ); Wed, 14 Aug 2019 16:11:03 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 13:11:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,386,1559545200"; d="scan'208";a="200992982" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by fmsmga004.fm.intel.com with ESMTP; 14 Aug 2019 13:11:02 -0700 Date: Wed, 14 Aug 2019 14:08:47 -0600 From: Keith Busch To: Mario Limonciello Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , "linux-nvme@lists.infradead.org" , LKML , Ryan Hong , Crag Wang , "sjg@google.com" , Charles Hyde , Jared Dominguez Subject: Re: [PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111 Message-ID: <20190814200847.GA3504@localhost.localdomain> References: <1565813304-16710-1-git-send-email-mario.limonciello@dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565813304-16710-1-git-send-email-mario.limonciello@dell.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 14, 2019 at 01:08:24PM -0700, Mario Limonciello wrote: > One of the components in LiteON CL1 device has limitations that > can be encountered based upon boundary race conditions using the > nvme bus specific suspend to idle flow. > > When this situation occurs the drive doesn't resume properly from > suspend-to-idle. > > LiteON has confirmed this problem and fixed in the next firmware > version. As this firmware is already in the field, avoid running > nvme specific suspend to idle flow. > > Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend") > Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html > Signed-off-by: Mario Limonciello > Signed-off-by: Charles Hyde Looks fine to me. Reviewed-by: Keith Busch