From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF22C433FF for ; Wed, 14 Aug 2019 22:42:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DA0921721 for ; Wed, 14 Aug 2019 22:42:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="PzkYxpR+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728887AbfHNWmI (ORCPT ); Wed, 14 Aug 2019 18:42:08 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:41456 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727273AbfHNWmI (ORCPT ); Wed, 14 Aug 2019 18:42:08 -0400 Received: by mail-pl1-f196.google.com with SMTP id m9so254737pls.8 for ; Wed, 14 Aug 2019 15:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hMEHK3D0DeqRXHR3V666QBC5hkX1AwG9+yo5maZ51Ws=; b=PzkYxpR+WsvJ0GKSPP9wt0l4YqVfxxZlRPySwxDENc0uquYDE4FH3bIiRoxfTPA1v0 daLJqf8B4sQuDac5d61sdyojfc8b9g9yhK52TGU9vCCC2Q6Ozm2F1P/8FaMyzsrTVEb0 3Xm3jaPn/9nJxAF4SojpaoPdnkNoRcv5nmLjQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hMEHK3D0DeqRXHR3V666QBC5hkX1AwG9+yo5maZ51Ws=; b=kMtqqGO2/jhiOJqAjjJRdwkbq3d75X0r85kZaphpBZc7bvTyu3hbLhHLGafiTFpwFN ybaiYLnjczhWAVctUCPCfc5LC2P36u4ZxRUFBeqWcXt9PH+mjuZP45kjgbnzWMZFFF9V Zu3OReGh6U2rUhXK9ijvrngCIvG2L6fc9DRfiehdrGHaR510q6/LQ6vTFpg8vmx7wNLI FT916w3N2O3ctTep6AF2CYXx/SMgtv4euetv1G/TIlYAdNajeCcmw1YbKGKUuoEmGzKF GaltyTf5OqYMepo7qFDH0TB7r8pWyZFENUfOmg8M7Vc9EzeszSKLkjF+zE/K6feIsk/1 0DDA== X-Gm-Message-State: APjAAAWm5QOrbHwyOr5UBRA6W3TKUK3EVwxKnZUGvJ2Ee3eKdfQLvRk4 pmoURJPCQIAGZv761bCN7rKsBA== X-Google-Smtp-Source: APXvYqxeCtn5YQ0RrQb6xdht/iQSMOK2IulsqUWdD2tppaE3yQNeQo12jNVOsbuEuixCZiNvYLOGgg== X-Received: by 2002:a17:902:2f05:: with SMTP id s5mr1571241plb.170.1565822527290; Wed, 14 Aug 2019 15:42:07 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id v6sm31357pjn.13.2019.08.14.15.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2019 15:42:06 -0700 (PDT) Date: Wed, 14 Aug 2019 18:42:05 -0400 From: Joel Fernandes To: Tejun Heo Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jonathan Corbet , Josh Triplett , Lai Jiangshan , linux-doc@vger.kernel.org, Mathieu Desnoyers , "Paul E. McKenney" , "Rafael J. Wysocki" , rcu@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH 1/3] workqueue: Convert for_each_wq to use built-in list check (v2) Message-ID: <20190814224205.GC69375@google.com> References: <20190811221111.99401-1-joel@joelfernandes.org> <20190814194841.GA588936@devbig004.ftw2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814194841.GA588936@devbig004.ftw2.facebook.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 14, 2019 at 12:48:41PM -0700, Tejun Heo wrote: > Hello, Joel. > > On Sun, Aug 11, 2019 at 06:11:09PM -0400, Joel Fernandes (Google) wrote: > > list_for_each_entry_rcu now has support to check for RCU reader sections > > as well as lock. Just use the support in it, instead of explicitly > > checking in the caller. > > > > Signed-off-by: Joel Fernandes (Google) > > Acked-by: Tejun Heo Thanks. > > #define for_each_pwq(pwq, wq) \ > > - list_for_each_entry_rcu((pwq), &(wq)->pwqs, pwqs_node) \ > > - if (({ assert_rcu_or_wq_mutex(wq); false; })) { } \ > > - else > > + list_for_each_entry_rcu((pwq), &(wq)->pwqs, pwqs_node, \ > > + lock_is_held(&(wq->mutex).dep_map)) > > Why not lockdep_is_held() tho? Yes, that's better. thanks, - Joel