From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E40C433FF for ; Wed, 14 Aug 2019 22:53:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75290214C6 for ; Wed, 14 Aug 2019 22:53:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Lxv3421X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729080AbfHNWx6 (ORCPT ); Wed, 14 Aug 2019 18:53:58 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:57970 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728692AbfHNWx6 (ORCPT ); Wed, 14 Aug 2019 18:53:58 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3CDF42B2; Thu, 15 Aug 2019 00:53:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1565823236; bh=CL84GQStNil7GZQgqIhkQ2ibX45iAPYQVUl32fqY34g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lxv3421XVhXPBCrb/G2YQqWu1tUXBmTyodkTiTzktnWgYp7LzrNR66ZJzRp5NHns7 UulmXilClz/bllnLRrnfwMZbex0/y9RzAHFfKsFtbyqM7OHFKV8lau6zRSww0K5Nd0 aoRNQtGkhlPpwMHGp8Jpfh+ijUVnsa7y2s5tE4Q4= Date: Thu, 15 Aug 2019 01:53:53 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" , open list Subject: Re: [RFC 3/5] media: v4l2-ctrls: Add support for V4L2_CID_LOCATION Message-ID: <20190814225353.GE5015@pendragon.ideasonboard.com> References: <20190814202815.32491-1-jacopo@jmondi.org> <20190814202815.32491-4-jacopo@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190814202815.32491-4-jacopo@jmondi.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, Thank you for the patch. On Wed, Aug 14, 2019 at 10:28:13PM +0200, Jacopo Mondi wrote: > Add support for the newly defined V4L2_CID_LOCATION read-only control > used to report the camera device mounting position. > > Signed-off-by: Jacopo Mondi > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++++++ > include/uapi/linux/v4l2-controls.h | 4 ++++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c > index 7d3a33258748..8ab0857df59a 100644 > --- a/drivers/media/v4l2-core/v4l2-ctrls.c > +++ b/drivers/media/v4l2-core/v4l2-ctrls.c > @@ -943,6 +943,7 @@ const char *v4l2_ctrl_get_name(u32 id) > case V4L2_CID_AUTO_FOCUS_RANGE: return "Auto Focus, Range"; > case V4L2_CID_PAN_SPEED: return "Pan, Speed"; > case V4L2_CID_TILT_SPEED: return "Tilt, Speed"; > + case V4L2_CID_LOCATION: return "Location"; Depending on what we decide to name the control (see review of 2/5), you should adjust the description accordingly. > > /* FM Radio Modulator controls */ > /* Keep the order of the 'case's the same as in v4l2-controls.h! */ > @@ -1300,6 +1301,12 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, > break; > case V4L2_CID_MPEG_VIDEO_FWHT_PARAMS: > *type = V4L2_CTRL_TYPE_FWHT_PARAMS; > + case V4L2_CID_LOCATION: > + *type = V4L2_CTRL_TYPE_INTEGER; > + *flags |= V4L2_CTRL_FLAG_READ_ONLY; > + *min = V4L2_LOCATION_FRONT; > + *max = V4L2_LOCATION_BACK; I don't think the control should have a min and a max different than the current value, as it's a fully static control. I'd drop those two lines here, and drivers will have to set value = min = max = V4L2_LOCATION_xxx when creating the control. That why you should be able to collapse this with V4L2_CID_MIN_BUFFERS_FOR_OUTPUT. > + *step = 1; > break; > default: > *type = V4L2_CTRL_TYPE_INTEGER; > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > index 37807f23231e..5c4c7b245921 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/v4l2-controls.h > @@ -889,6 +889,10 @@ enum v4l2_auto_focus_range { > #define V4L2_CID_PAN_SPEED (V4L2_CID_CAMERA_CLASS_BASE+32) > #define V4L2_CID_TILT_SPEED (V4L2_CID_CAMERA_CLASS_BASE+33) > > +#define V4L2_CID_LOCATION (V4L2_CID_CAMERA_CLASS_BASE+34) > +#define V4L2_LOCATION_FRONT (0 << 0) > +#define V4L2_LOCATION_BACK (1 << 0) Why not just 0 and 1 ? > + > /* FM Modulator class control IDs */ > > #define V4L2_CID_FM_TX_CLASS_BASE (V4L2_CTRL_CLASS_FM_TX | 0x900) -- Regards, Laurent Pinchart