From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB029C3A589 for ; Thu, 15 Aug 2019 12:38:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB69421743 for ; Thu, 15 Aug 2019 12:38:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bU7F69Oa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731861AbfHOMiU (ORCPT ); Thu, 15 Aug 2019 08:38:20 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:37481 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbfHOMiU (ORCPT ); Thu, 15 Aug 2019 08:38:20 -0400 Received: by mail-pl1-f194.google.com with SMTP id bj8so1039177plb.4; Thu, 15 Aug 2019 05:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1ee2WC7wFUitxl0VhlNk/I0IaNSildZhX3LeEHVWcaU=; b=bU7F69OaIb5ke+Qt0qr7HlZwNfbiYKkzBNNDd8WzOHgsvEfE1khSOgq2w7EpiRuWPh uTqfEiRYLy6fq3vEnJnH7/iPX37E1FVbVulx7Vv4U18g2VLI86sei7DpxGqKZDZ96V8+ rSoDO6VJthK6lxxQXoyz0eywkCeUmf/HVebo2WM0qgyPW9iHxjb5jXIwCH/78l9samiB m2STME5iKjiocHcUzIBq5wqyuPgAlKn7Cq1b3FOToXEt7XIEjowRnd3jV3pH+WCgbrwb y/wg7L3zNnBb2BOCFeUQahe99n0O2JYWx17ui9xB37TfI3KFvJtxA92FplWroT1DsaAR LHVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1ee2WC7wFUitxl0VhlNk/I0IaNSildZhX3LeEHVWcaU=; b=ovbZ5cY9Trf6ZwcGv1tYn/TZUTd+r7paJG4+Q5oFgYBYbVsvoewwFhgpB4eNPFlTxI jC9jY0iNn7t7e74onD8L0NcWQQFnmHwPF10gIIoKS1ijpZ5vpjI31Gmhnd2616ZwhO/D +hSDlydnoBQceM8gm9y3+0Y2E5jAX37hF+uKWCIbvSo6sE1FbQUl8bfZPrYVlctdnM5J 6MLCJeLG3TTRS9pD2Il8x3sXkQNsm3riUVG5lJ22bFoRs/eZyWWxa6w5G9SkR2/x8hbo a95v+VwN4FeDcteDIJSd5QzxGFd92DllBoHg06K3IL3xe/EPNKrCEQezfy+DA28eh8n3 VwTg== X-Gm-Message-State: APjAAAW4Q1sF4cJSddhaYGVhTutcImjlbyFSSC+7b+p3BbND4I/mSz3L Tk6BajHMEOfijOLvFgXpwkk= X-Google-Smtp-Source: APXvYqwacwndMgsXukx1fTNdcEaTu+xtzJYP9eajJDSzmxObARVKtVJS5xCwgo93gUEa6Hu2wopekQ== X-Received: by 2002:a17:902:e60c:: with SMTP id cm12mr2573361plb.304.1565872699079; Thu, 15 Aug 2019 05:38:19 -0700 (PDT) Received: from icarus ([2001:268:c146:4483:71c4:4d14:b4c7:2693]) by smtp.gmail.com with ESMTPSA id t4sm2836798pfd.109.2019.08.15.05.38.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Aug 2019 05:38:17 -0700 (PDT) Date: Thu, 15 Aug 2019 21:37:58 +0900 From: William Breathitt Gray To: David Lechner Cc: linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, Rob Herring , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , Tony Lindgren , Thierry Reding , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Jonathan Cameron Subject: Re: [PATCH v2 3/5] counter: new TI eQEP driver Message-ID: <20190815123758.GA646493@icarus> References: <20190807194023.15318-1-david@lechnology.com> <20190807194023.15318-4-david@lechnology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190807194023.15318-4-david@lechnology.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 07, 2019 at 02:40:21PM -0500, David Lechner wrote: > +static struct counter_synapse ti_eqep_position_synapses[] = { > + { > + .action = TI_EQEP_SYNAPSE_ACTION_BOTH_EDGES, > + .actions_list = ti_eqep_position_synapse_actions, > + .num_actions = ARRAY_SIZE(ti_eqep_position_synapse_actions), > + .signal = &ti_eqep_signals[TI_EQEP_SIGNAL_QEPA], > + }, > + { > + .action = TI_EQEP_SYNAPSE_ACTION_BOTH_EDGES, > + .actions_list = ti_eqep_position_synapse_actions, > + .num_actions = ARRAY_SIZE(ti_eqep_position_synapse_actions), > + .signal = &ti_eqep_signals[TI_EQEP_SIGNAL_QEPB], > + }, > +}; Hi David, Just a minor suggestion for your v3: you don't need to initialize "action" here since it'll be automatically updated in the core counter_action_show function to the value returned by your action_get callback function. So you can safely delete those two ".action =" lines. William Breathitt Gray