Re: [PATCH v3 2/4] tpm: tpm_tis_spi: Export functionality to other drivers

Jarkko Sakkinen
2019-08-09T20:28:23Z

On Tue, 2019-08-06 at 15:07 -0700, Stephen Boyd wrote:
> We want to use most of the code in this driver, except we want to modify
> the flow control and idle behavior. Let's "libify" this driver so that
> another driver can call the code in here and slightly tweak the
> behavior.

Neither "libifying" nor "slightly tweaking" gives an idea what the
commit does. A great commit message should be in imperative form
describe what it does and why in as plain english as possible.

Often commit messages are seen just as a necessary bad and not much
energy is spent on them but for a maitainer solid commit messages have
an indispensable value.

> + void (*pre_transfer)(struct tpm_tis_spi_phy *phy);

Adding a new calback should be a commit of its own.

/Jarkko