Re: [PATCH] csky: Fixup ioremap function losing

Guo Ren
2019-08-20T08:26:45Z

On Mon, Aug 19, 2019 at 2:21 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Sun, Aug 18, 2019 at 10:20:18AM +0800, Guo Ren wrote:
> > > > Also change flag VM_ALLOC to VM_IOREMAP in get_vm_area_caller.
> > >
> > > Looks generally fine, but two comments:
> > >
> > > - do you have a need for ioremap_cache? We are generally try to
> > > phase it out in favour of memremap, and it is generally only used
> > > by arch specific code.
> > Yes, some drivers of our customers use ioremap_cache to map phy_addr
> > which isn't belong to system memory.
>
> Which driver? We should move it over to memremap instead of adding
> a new ioremap_cache.
The driver hasn't been upstreamed. OK, just remove ioremap_cache and
seems it's not a big problem.

--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/