Re: [PATCH] csky: Fixup ioremap function losing

Christoph Hellwig
2019-08-16T07:03:55Z

On Thu, Aug 15, 2019 at 07:28:57PM +0800, guoren@kernel.org wrote:
> From: Guo Ren <ren_guo@c-sky.com>
>
> Implement the following apis to meet usage in different scenarios.
>
> - ioremap (NonCache + StrongOrder)
> - ioremap_nocache (NonCache + StrongOrder)
> - ioremap_wc (NonCache + WeakOrder )
> - ioremap_cache ( Cache + WeakOrder )
>
> Also change flag VM_ALLOC to VM_IOREMAP in get_vm_area_caller.

Looks generally fine, but two comments:

- do you have a need for ioremap_cache? We are generally try to
phase it out in favour of memremap, and it is generally only used
by arch specific code.
- I have a big series pending to clean up the mess with our
ioremap_* functions, including adding a generic implementation
that csky should be able to use. Unless this patch is urgent it
might make sense to rebase it on top. Here is my current tree, I
plan to post it soon: