From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC36C3A59C for ; Fri, 16 Aug 2019 08:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE62E20644 for ; Fri, 16 Aug 2019 08:23:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kde.org header.i=@kde.org header.b="kr98yFWL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726864AbfHPIXR (ORCPT ); Fri, 16 Aug 2019 04:23:17 -0400 Received: from letterbox.kde.org ([46.43.1.242]:36654 "EHLO letterbox.kde.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbfHPIXQ (ORCPT ); Fri, 16 Aug 2019 04:23:16 -0400 Received: from archbox.localdomain (unknown [203.187.238.17]) (Authenticated sender: bshah) by letterbox.kde.org (Postfix) with ESMTPSA id B6752288870; Fri, 16 Aug 2019 09:23:13 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kde.org; s=users; t=1565943794; bh=R+mo2BGavCwf8Mztq2UzfRe5LGcuCVb+205qaTnZVtI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kr98yFWLu1zfwT7VtWyOw/fahFFRPdXW+MlNuqGfbct+aMHVojSxkWWHfh3DF2HiU g94g6LL8JSox9npC0r6JkcyJTVd2XZTHyAdswwXfYEJucEFRpZdWK0TRz/mnMAhalH BLFZCkfgIINs6VdaIeYsettvt1ZPkRlpo0TLF8MlDchMDswqf4nHC92bmpj2g1chao q2lc3VjQhjiFAKLqzW+OMUD/3P29ossSwxjJvEos1S5dv/wdCvUT/0WAAr57UMt26i Ki5vyKJ8tIc+vPDGypIkbdwCYJTuo8F6KQ4m6CgzfP8r8XsjwiZFkSoAbvKcz/BbL4 eafiysNJHUpBQ== Date: Fri, 16 Aug 2019 13:53:11 +0530 From: Bhushan Shah To: Maxime Ripard Cc: Bhushan Shah , Icenowy Zheng , Rob Herring , Mark Rutland , Chen-Yu Tsai , Wolfram Sang , Gregory CLEMENT , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] arm64: allwinner: h6: add I2C nodes Message-ID: <20190816082311.GB18236@pyxis> References: <20190811090503.32396-1-bshah@kde.org> <20190816064710.18280-1-bshah@kde.org> <20190816064710.18280-3-bshah@kde.org> <20190816075031.zw4bjunn4hfoaq3e@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Pd0ReVV5GZGQvF3a" Content-Disposition: inline In-Reply-To: <20190816075031.zw4bjunn4hfoaq3e@flea> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Pd0ReVV5GZGQvF3a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 16, 2019 at 09:50:31AM +0200, Maxime Ripard wrote: > On Fri, Aug 16, 2019 at 12:17:09PM +0530, Bhushan Shah wrote: > > Add device-tree nodes for i2c0 to i2c2, and also add relevant pinctrl > > nodes. > > > > Suggested-by: Icenowy Zheng > > Signed-off-by: Bhushan Shah > > --- > > Changes in v2: > > - Add the SoC specific compatible string instead of re-using a31 one. > > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 56 +++++++++++++++++++- > > 1 file changed, 55 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/= boot/dts/allwinner/sun50i-h6.dtsi > > index bcecca17d61d..a1a329926540 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -329,6 +329,21 @@ > > function =3D "hdmi"; > > }; > > > > + i2c0_pins: i2c0-pins { > > + pins =3D "PD25", "PD26"; > > + function =3D "i2c0"; > > + }; > > + > > + i2c1_pins: i2c1-pins { > > + pins =3D "PH5", "PH6"; > > + function =3D "i2c1"; > > + }; > > + > > + i2c2_pins: i2c2-pins { > > + pins =3D "PD23", "PD24"; > > + function =3D "i2c2"; > > + }; > > + > > mmc0_pins: mmc0-pins { > > pins =3D "PF0", "PF1", "PF2", "PF3", > > "PF4", "PF5"; > > @@ -464,6 +479,45 @@ > > status =3D "disabled"; > > }; > > > > + i2c0: i2c@5002000 { > > + compatible =3D "allwinner,sun50i-h6-i2c"; >=20 > This isn't going to work if you don't patch the driver to add the > compatible. And this isn't what you described in the binding patch. oops, I will correct this in next patch series. Sorry. >=20 > Maxime >=20 > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com --=20 Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D --Pd0ReVV5GZGQvF3a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEs8s2ZVJUC+Bu6a2XEZaMRJKMrvwFAl1WZ+4ACgkQEZaMRJKM rvxqAQgAjTTOPqp4IbGW4/nDm8BBmNiePwfg57R8R49Uy4uEW2aWag5VAObJy66F cWkU8CtYUYXWPvnke18zDyH+EqqgJgraUnNyU1Slj3e6kylEvREKRsM4W9u8m4ti r88PZiTtWmPLmAYOrzIUVckEwDau21Apeqjf1+Tqq2Q3xCGx2vRPBsm59972SGVY yT8k1SWABM5m42rko8rQh+XZ9u0niBliD1u4+KY8zQ9Uu/g8T/t7JcCu+ysy8U+W esnMrLdwMChMpjDzAX1vdkAexCAo5E6/NeDbcQWJqxjqCDX5oy/vIXlydKl1Sczx DrysSQzkyw8rbwv9OGMC+YtpVHjAYA== =gJ/S -----END PGP SIGNATURE----- --Pd0ReVV5GZGQvF3a--