From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD90DC3A59C for ; Fri, 16 Aug 2019 09:35:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8162521655 for ; Fri, 16 Aug 2019 09:35:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EuBdvrGE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727076AbfHPJfT (ORCPT ); Fri, 16 Aug 2019 05:35:19 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38263 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726879AbfHPJfT (ORCPT ); Fri, 16 Aug 2019 05:35:19 -0400 Received: by mail-wm1-f66.google.com with SMTP id m125so3531027wmm.3; Fri, 16 Aug 2019 02:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rbr1jopCtEP3uUBd65SxG5GDcmjxQ0jQZ9rlFzdVGBM=; b=EuBdvrGE0ubQvEt+M3mSAC0JjzxeRNOmdv7mzpRm5xWy0VsOxsWBMe6IjzBJhIY2B4 NgYq1kWWWRv0GJU7LSbwUx3z8/Kc9Bw4Q/SHgQeOeGLYKbEhPu4mbifvO9xB5+6w4NQr s+5yAmQJzhdBEqOiPPNdl1HSGg1nbOI5uSKak28gr34lHJuT9s9PxROhSELUvP0dnIbx 1ggO5FAm9aPTkHMi7VqbekutqvJJvckN/l9niEeJHmIHfZpJlrDdQZ8etFuQrNSiAYu+ ecJJizw/qv/yQSifb5PBIhDeKc9fn/5w73217/H6g0iPdrK2IbdwUqb+o0kY/u2meNpv QR+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rbr1jopCtEP3uUBd65SxG5GDcmjxQ0jQZ9rlFzdVGBM=; b=EE/nI4n+NlYUeMA5MIFLtZIWlVgHjT6UbJXRvROe/iwvqGGb31Pk1IkOf4BggAaTbe 1DIpWIjPs2wLGjUV5uxDFXcK+sPuOaGOfxlrhllITUWknc/xGPzUVsBnyvFs47qVCmFj 94iNXHiZGkzeNW0GvB2fhtG9h9NUXynZgOPV1AW592QxbNXKmVZM/hML95O1mNQB70qA Z9THUwhsjA71QYCoj5nF+t/hmEQa3EqJPgvH92LDynd5AfBEsAbACOY6SNsUB8Q8UyEI x/iSLWu7xl1j3szP9Fam4S6Ss+NaQWDP2NY0i8nqhrz/oHck/S4aejAp5KuEoyDAIZFR pliw== X-Gm-Message-State: APjAAAUywobLHwOXQLFMvGtlVPaKQzFKMrTQNFrrLvlOWpP3YZwBdmHg YT4XOwzVWVSKonSkfc5P7tA= X-Google-Smtp-Source: APXvYqy2Ze5R7JhzotwLUUfhPTfgK7a1GBPQV3583GsixouocQNDNqD3jX9If6rReradtPZ+4oRZuw== X-Received: by 2002:a7b:c091:: with SMTP id r17mr5916128wmh.74.1565948116827; Fri, 16 Aug 2019 02:35:16 -0700 (PDT) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id m23sm6600892wml.41.2019.08.16.02.35.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Aug 2019 02:35:16 -0700 (PDT) Date: Fri, 16 Aug 2019 11:35:13 +0200 From: Corentin Labbe To: Maxime Ripard Cc: mark.rutland@arm.com, robh+dt@kernel.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH] ARM64: dts: allwinner: Add devicetree for pine H64 modelA evaluation board Message-ID: <20190816093513.GA25042@Red> References: <20190808084253.10573-1-clabbe.montjoie@gmail.com> <20190812094000.ebdmhyxx7xzbevef@flea> <20190814131741.GB24324@Red> <20190814133322.dawzv3ityakxtqs4@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814133322.dawzv3ityakxtqs4@flea> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 14, 2019 at 03:33:22PM +0200, Maxime Ripard wrote: > On Wed, Aug 14, 2019 at 03:17:41PM +0200, Corentin Labbe wrote: > > On Mon, Aug 12, 2019 at 11:40:00AM +0200, Maxime Ripard wrote: > > > On Thu, Aug 08, 2019 at 10:42:53AM +0200, Corentin Labbe wrote: > > > > This patch adds the evaluation variant of the model A of the PineH64. > > > > The model A has the same size of the pine64 and has a PCIE slot. > > > > > > > > The only devicetree difference with current pineH64, is the PHY > > > > regulator. > > > > > > > > Signed-off-by: Corentin Labbe > > > > --- > > > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > > > .../sun50i-h6-pine-h64-modelA-eval.dts | 26 +++++++++++++++++++ > > > > 2 files changed, 27 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > > > > index f6db0611cb85..9a02166cbf72 100644 > > > > --- a/arch/arm64/boot/dts/allwinner/Makefile > > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile > > > > @@ -25,3 +25,4 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb > > > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelA-eval.dtb > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts > > > > new file mode 100644 > > > > index 000000000000..d8ff02747efe > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts > > > > @@ -0,0 +1,26 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > > > > +/* > > > > + * Copyright (C) 2019 Corentin Labbe > > > > + */ > > > > + > > > > +#include "sun50i-h6-pine-h64.dts" > > > > + > > > > +/ { > > > > + model = "Pine H64 model A evaluation board"; > > > > + compatible = "pine64,pine-h64-modelA-eval", "allwinner,sun50i-h6"; > > > > + > > > > + reg_gmac_3v3: gmac-3v3 { > > > > + compatible = "regulator-fixed"; > > > > + regulator-name = "vcc-gmac-3v3"; > > > > + regulator-min-microvolt = <3300000>; > > > > + regulator-max-microvolt = <3300000>; > > > > + startup-delay-us = <100000>; > > > > + gpio = <&pio 2 16 GPIO_ACTIVE_HIGH>; > > > > + enable-active-high; > > > > + }; > > > > + > > > > +}; > > > > + > > > > +&emac { > > > > + phy-supply = <®_gmac_3v3>; > > > > +}; > > > > > > I might be missing some context here, but I'm pretty sure that the > > > initial intent of the pine h64 DTS was to support the model A all > > > along. > > > > > > > The regulator changed between modelA and B. > > See this old patchset (supporting modelA) https://patchwork.kernel.org/patch/10539149/ for example. > > I'm not sure what your point is, but mine is that everything about the > model A should be in sun50i-h6-pine-h64.dts. > model A and B are different enough for distinct dtb, (see sub-thread on HDMI difference for an other difference than PHY regulator) And clearly, the current dtb is for model B. So do you mean that we need to create a new dtb for model B ? (and hack the current back to model A ?) Regards