From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F86C3A59C for ; Fri, 16 Aug 2019 13:21:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9299420644 for ; Fri, 16 Aug 2019 13:21:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bdoe+EPy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727302AbfHPNVQ (ORCPT ); Fri, 16 Aug 2019 09:21:16 -0400 Received: from mail-pl1-f172.google.com ([209.85.214.172]:35704 "EHLO mail-pl1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727087AbfHPNVQ (ORCPT ); Fri, 16 Aug 2019 09:21:16 -0400 Received: by mail-pl1-f172.google.com with SMTP id gn20so2459970plb.2 for ; Fri, 16 Aug 2019 06:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dm2N+LnWuHtZbkuSIck0zIcrvDsNHqwjs1kno32i+NQ=; b=Bdoe+EPyJIVt0t4vtNlH3KtR97Uv+lIglmMvP9oVETaOhMb+OsBJBYdKEl2FqG4npb FKKbloJWQQBhLJ2altHF5EOizbJD3qSmt9okzqqKsWIRYBdLEkGtHFs731ihxLty3TUC kgkjyN94T3r46VAC0bHTLz26wdM+WhZbYjLXu02lqXIpfyQhRTerQwuAXbuTqsDBdLWE kvXX2rTNUp0qb4+8nmSkJzJzCJZ4bt3wSyu48WnFkf/FIsDIjvn4FA8eb6ZNa9/Jhq3C aC6fMBrfgQKu9fiGJZ4ESItwoOimDspMMwM5F7upsNxUdKmOmfd8C+9gfuH28qCDi0Vb 9HpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dm2N+LnWuHtZbkuSIck0zIcrvDsNHqwjs1kno32i+NQ=; b=TTWHFxhKjb3kGRfLdEs672u5ZSmYi+x2jwKRfVQMti6fklnOegvIM66q5Nmf/hHEIv BlASukublOuLoPbwnuw+Ovj3LNqxDHvhWwbZo+bTdjcEagFZRtCF0FIzJcg6JWw+Zvw7 VRkhoe6m4ZtDyvHSqVD5IdRsuc2omPTNNas7wqpiMEO7IprkEbrMJIf0b/k9ttB1/Otn BwwOO3PJ91/u5msX8O0VSHKL2s5ehVseFTXvob94GvVqoNsHwZC2Bo1LfIMiR2qjx5tE BGRYoRYebOEs3syyONpITRu9jjDhss0F/Zi/VrXIPonuKP1ABUqx4wHIMwTmcxBX2kTC xpJA== X-Gm-Message-State: APjAAAVs4fwOK7fM3en6R2eCZHivQ6FJ/ZIWnux/LByA0VzoR/Qjtrct 0oWwH5kimfuu+8grFuEKig== X-Google-Smtp-Source: APXvYqydGyP1mgEtu3qW6HKoHuLtWSwwvIrW5xwjx4KYVdKuvGs6ug/t1qFEg81KA7jnC2oBLt7JpQ== X-Received: by 2002:a17:902:4401:: with SMTP id k1mr9272692pld.193.1565961675287; Fri, 16 Aug 2019 06:21:15 -0700 (PDT) Received: from mypc ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id d12sm6107656pfn.11.2019.08.16.06.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 06:21:12 -0700 (PDT) Date: Fri, 16 Aug 2019 21:21:02 +0800 From: Pingfan Liu To: Jerome Glisse Cc: Ralph Campbell , linux-mm@kvack.org, Andrew Morton , Mel Gorman , Jan Kara , "Kirill A. Shutemov" , Michal Hocko , Mike Kravetz , Andrea Arcangeli , Matthew Wilcox , linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] mm/migrate: clean up useless code in migrate_vma_collect_pmd() Message-ID: <20190816132102.GA10848@mypc> References: <20190807052858.GA9749@mypc> <1565167272-21453-1-git-send-email-kernelfans@gmail.com> <20190815171918.GC30916@redhat.com> <20190815194021.GB9253@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190815194021.GB9253@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 15, 2019 at 03:40:21PM -0400, Jerome Glisse wrote: > On Thu, Aug 15, 2019 at 12:23:44PM -0700, Ralph Campbell wrote: > [...] > > > > I don't understand. The only use of "pfn" I see is in the "else" > > clause above where it is set just before using it. > > Ok i managed to confuse myself with mpfn and probably with old > version of the code. Sorry for reading too quickly. Can we move > unsigned long pfn; into the else { branch so that there is no > more confusion to its scope. Looks better, I will update v3. Thanks, Pingfan