From: Ladislav Michl <ladis@linux-mips.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: vkoul@kernel.org, sanyog.r.kale@intel.com,
pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH -next] soundwire: Fix -Wunused-function warning
Date: Fri, 16 Aug 2019 18:02:15 +0200 [thread overview]
Message-ID: <20190816160215.GA6048@lenoch> (raw)
In-Reply-To: <20190816141409.49940-1-yuehaibing@huawei.com>
On Fri, Aug 16, 2019 at 10:14:09PM +0800, YueHaibing wrote:
> If CONFIG_ACPI is not set, gcc warning this:
>
> drivers/soundwire/slave.c:16:12: warning:
> 'sdw_slave_add' defined but not used [-Wunused-function]
>
> move them to #ifdef CONFIG_ACPI block.
...and that makes slave.c empty, right? So it boils down to
obj-$(CONFIG_ACPI) += slave.o
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/soundwire/slave.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
> index f39a581..34c7e65 100644
> --- a/drivers/soundwire/slave.c
> +++ b/drivers/soundwire/slave.c
> @@ -6,6 +6,7 @@
> #include <linux/soundwire/sdw_type.h>
> #include "bus.h"
>
> +#if IS_ENABLED(CONFIG_ACPI)
> static void sdw_slave_release(struct device *dev)
> {
> struct sdw_slave *slave = dev_to_sdw_dev(dev);
> @@ -60,7 +61,6 @@ static int sdw_slave_add(struct sdw_bus *bus,
> return ret;
> }
>
> -#if IS_ENABLED(CONFIG_ACPI)
> /*
> * sdw_acpi_find_slaves() - Find Slave devices in Master ACPI node
> * @bus: SDW bus instance
> --
> 2.7.4
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-08-16 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 14:14 [PATCH -next] soundwire: Fix -Wunused-function warning YueHaibing
2019-08-16 16:02 ` Ladislav Michl [this message]
2019-08-22 14:54 ` [PATCH v2 " YueHaibing
2019-08-23 6:44 ` Vinod Koul
2019-08-23 8:10 ` Yuehaibing
2019-08-25 2:36 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816160215.GA6048@lenoch \
--to=ladis@linux-mips.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox