From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71DC7C3A59C for ; Fri, 16 Aug 2019 17:24:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 462822086C for ; Fri, 16 Aug 2019 17:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S+ej47Pl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727555AbfHPRY0 (ORCPT ); Fri, 16 Aug 2019 13:24:26 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:39381 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727500AbfHPRYZ (ORCPT ); Fri, 16 Aug 2019 13:24:25 -0400 Received: by mail-pf1-f193.google.com with SMTP id f17so3439498pfn.6; Fri, 16 Aug 2019 10:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ngcVh8zrx60LXZVea+w+3KhZZLQW588vJoNhzWNNbZw=; b=S+ej47PlpzF4EQnmwkvkdAXiKugoKO2KNHDdctm3C3gk52iC1zdCU1nNSZcS8bPajh SsTR6g6S/a1zPxSArdj5fhnsgMEPeFABm4IDIYzbQ/6n2waKBhWnoboDVJJjajxXHxEU EFuN9lqZDDLrq4I0yom7RKSJLuf2M97TC8nKtTbLpjJl9VOhSA/TXsVO3FKS1JAMrhA/ +KfWUjyDXriIJHanMlMR118SSzT+hx7YfP66nqB2ekW0G11TvbccViYi2JPyw9dv2u5j 5oqe0ft6f8T7S0l8dc5WiiroGzxiUG1dyuEa91iaeHMtMHsFk5VVmPpDR6NCdQ/roCHk CgPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ngcVh8zrx60LXZVea+w+3KhZZLQW588vJoNhzWNNbZw=; b=PfU9Lyby4KKsGBIyxd/w/1/Kv7s0rdGHQvlam5ddkCoCceAKqBBlYhv6hiPu999W3k 0t+klNxHS80Cfjtkbt6XnxFi1NP+AM5HsRVVTZFG0zwgI5E7TATTNKCwL31BVJN2aaP+ XSmcrASq+YEVZZmvC7WdAxGZZRu2LHpYvECTNCYUhTrVCtfecvr7cWdxHX6yGJt1KfiL kZpt4XvA6uD93iLJ7LZX0vFmEgVUFm+IlQRvIy9KpoVjthvSilSvdC7UzwYH3D14OFwg hC0vVQP3G45Z8SKKm2yp92A1BsEOeq29tUxDp9NonfZduQsjlpNQ+5qXolgGT5skrwQP rYDQ== X-Gm-Message-State: APjAAAVfZzL4IRQ7t8p5YOYSr+3Cq0FMW3cZgsm1craV5m6H7GZ0uXjm DlKfs4sc8ECA3hxCx7C/AV8= X-Google-Smtp-Source: APXvYqxmYjtZ8qZoW3pqorhENAO8Qi81BWqAQcRZvy1daRWpzTEbmLh/QknsvGfUTXJ7YBi56sIwyw== X-Received: by 2002:a17:90a:bc4b:: with SMTP id t11mr8448790pjv.87.1565976264912; Fri, 16 Aug 2019 10:24:24 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id o11sm7454547pfh.114.2019.08.16.10.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 10:24:24 -0700 (PDT) Date: Fri, 16 Aug 2019 10:24:22 -0700 From: Dmitry Torokhov To: Jiada Wang Cc: nick@shmanahar.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, george_davis@mentor.com Subject: Re: [PATCH v1 36/63] Input: atmel_mxt_ts - configure and use gpios as real gpios Message-ID: <20190816172422.GH121898@dtor-ws> References: <20190816083525.19071-1-jiada_wang@mentor.com> <20190816083525.19071-2-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190816083525.19071-2-jiada_wang@mentor.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2019 at 05:34:58PM +0900, Jiada Wang wrote: > From: Kautuk Consul > > The upstream Atmel mXT driver implementation seems to handle the > T19 GPIO/PWM object as a key pad. Keys can be defined in the > device tree ("linux,gpio-keymap") and will be transported as key > events to the Linux input device if GPIO state changes. > > With our hardware, the GPIO pins of the touch controller are > connected to a PWM/backlight controller and used as supervision > inputs. We like to read the status of the pins by a script or an > application in the sysfs. > > Adding newer sysfs entries which shall be placed in the input > class directory eg: > /sys/class/input/input/backlight_error1 No, if you want to export GPIO lines for external use create a gpiochip instance and register it with GPIO subsystem. No ad-hoc sysfs please. Thanks. -- Dmitry