From: Rob Herring <robh@kernel.org>
To: Ronen Krupnik <ronenk@amazon.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, barakw@amazon.com,
dwmw@amazon.co.uk, benh@amazon.com, jonnyc@amazon.com,
talel@amazon.com, hhhawa@amazon.com, hanochu@amazon.com
Subject: Re: [PATCH 1/2] dt-bindings: amazon: add Amazon Annapurna Labs Alpine support
Date: Fri, 16 Aug 2019 17:04:59 -0500 [thread overview]
Message-ID: <20190816220459.GA17518@bogus> (raw)
In-Reply-To: <20190728195135.12661-2-ronenk@amazon.com>
On Sun, Jul 28, 2019 at 10:51:34PM +0300, Ronen Krupnik wrote:
> This patch adds DT bindings info for Amazon Annapurna Labs Alpine SOC
> and related reference boards.
>
> Signed-off-by: Ronen Krupnik <ronenk@amazon.com>
> ---
> .../devicetree/bindings/arm/amazon,alpine.txt | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/amazon,alpine.txt
Board bindings are in DT schema format now.
Also, we already have al,alpine.yaml. Please combine with that one or
remove it perhaps. Seems kind of abandoned given the lack of response on
it.
>
> diff --git a/Documentation/devicetree/bindings/arm/amazon,alpine.txt b/Documentation/devicetree/bindings/arm/amazon,alpine.txt
> new file mode 100644
> index 000000000000..58817208421b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/amazon,alpine.txt
> @@ -0,0 +1,23 @@
> +Amazon Annapurna Labs Alpine v3 Platform Device Tree Bindings
> +---------------------------------------------------------------
> +
> +Platforms based on Amazon Annapurna Labs Alpine SoC architecture
> +shall follow the following scheme:
> +
> +SoCs
> +----
> +
> +Each device tree root node must specify which exact SoC in alpine
> +architecture it uses, using one of the following compatible values:
> +
> +- alpine v3
> + compatible = "amazon,alpine-v3";
> +
> +Boards
> +------
> +
> +Each device tree must specify which one or more of the following
> +board-specific compatible values:
> +
> +- alpine-v3 Evaluation Platform (EVP)
> + compatible = "amazon,alpine-v3-evp";
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-08-16 22:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 19:51 [PATCH 0/2] Amazon Annapurna Labs Alpine v3 device-tree Ronen Krupnik
2019-07-28 19:51 ` [PATCH 1/2] dt-bindings: amazon: add Amazon Annapurna Labs Alpine support Ronen Krupnik
2019-08-16 22:04 ` Rob Herring [this message]
2019-07-28 19:51 ` [PATCH 2/2] arm64: dts: amazon: add Amazon Annapurna Labs Alpine v3 support Ronen Krupnik
2019-07-29 10:12 ` Sudeep Holla
2019-08-06 10:02 ` Krupnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816220459.GA17518@bogus \
--to=robh@kernel.org \
--cc=barakw@amazon.com \
--cc=benh@amazon.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox