From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Hanzelik <matthew.hanzelik@gmail.com>
Cc: w.d.hubbs@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue
Date: Sat, 17 Aug 2019 09:00:37 +0200 [thread overview]
Message-ID: <20190817070037.GA14489@kroah.com> (raw)
In-Reply-To: <20190817065426.2090-1-matthew.hanzelik@gmail.com>
On Sat, Aug 17, 2019 at 02:54:26AM -0400, Matthew Hanzelik wrote:
> Fixed an unnamed parameter style issue.
>
> Signed-off-by: Matthew Hanzelik <matthew.hanzelik@gmail.com>
> ---
> drivers/staging/speakup/spk_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
> index a2fc72c29894..afa64eb9afb4 100644
> --- a/drivers/staging/speakup/spk_types.h
> +++ b/drivers/staging/speakup/spk_types.h
> @@ -189,7 +189,7 @@ struct spk_synth {
> void (*flush)(struct spk_synth *synth);
> int (*is_alive)(struct spk_synth *synth);
> int (*synth_adjust)(struct st_var_header *var);
> - void (*read_buff_add)(u_char);
> + void (*read_buff_add)(u_char *add);
You just changed the function prototype from taking a single character,
to taking a pointer to a character, are you sure this is correct?
No other build warnings with this patch enabled?
thanks,
greg k-h
next prev parent reply other threads:[~2019-08-17 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-17 6:54 [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue Matthew Hanzelik
2019-08-17 7:00 ` Greg KH [this message]
2019-08-17 17:44 ` kbuild test robot
2019-08-27 13:19 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190817070037.GA14489@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.hanzelik@gmail.com \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox