* Re: [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue
2019-08-17 6:54 [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue Matthew Hanzelik
@ 2019-08-17 7:00 ` Greg KH
2019-08-17 17:44 ` kbuild test robot
2019-08-27 13:19 ` kbuild test robot
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-08-17 7:00 UTC (permalink / raw)
To: Matthew Hanzelik; +Cc: w.d.hubbs, devel, linux-kernel
On Sat, Aug 17, 2019 at 02:54:26AM -0400, Matthew Hanzelik wrote:
> Fixed an unnamed parameter style issue.
>
> Signed-off-by: Matthew Hanzelik <matthew.hanzelik@gmail.com>
> ---
> drivers/staging/speakup/spk_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
> index a2fc72c29894..afa64eb9afb4 100644
> --- a/drivers/staging/speakup/spk_types.h
> +++ b/drivers/staging/speakup/spk_types.h
> @@ -189,7 +189,7 @@ struct spk_synth {
> void (*flush)(struct spk_synth *synth);
> int (*is_alive)(struct spk_synth *synth);
> int (*synth_adjust)(struct st_var_header *var);
> - void (*read_buff_add)(u_char);
> + void (*read_buff_add)(u_char *add);
You just changed the function prototype from taking a single character,
to taking a pointer to a character, are you sure this is correct?
No other build warnings with this patch enabled?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue
2019-08-17 6:54 [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue Matthew Hanzelik
2019-08-17 7:00 ` Greg KH
@ 2019-08-17 17:44 ` kbuild test robot
2019-08-27 13:19 ` kbuild test robot
2 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2019-08-17 17:44 UTC (permalink / raw)
To: Matthew Hanzelik
Cc: kbuild-all, w.d.hubbs, devel, Matthew Hanzelik, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 3155 bytes --]
Hi Matthew,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc4 next-20190816]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Matthew-Hanzelik/Staging-speakup-spk_types-fixed-an-unnamed-parameter-style-issue/20190817-235230
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/staging/speakup/serialio.c: In function 'synth_readbuf_handler':
>> drivers/staging/speakup/serialio.c:120:24: warning: passing argument 1 of 'synth->read_buff_add' makes pointer from integer without a cast [-Wint-conversion]
synth->read_buff_add((u_char)c);
^
drivers/staging/speakup/serialio.c:120:24: note: expected 'u_char * {aka unsigned char *}' but argument is of type 'unsigned char'
--
drivers/staging/speakup/spk_ttyio.c: In function 'spk_ttyio_receive_buf2':
>> drivers/staging/speakup/spk_ttyio.c:82:35: warning: passing argument 1 of 'spk_ttyio_synth->read_buff_add' makes pointer from integer without a cast [-Wint-conversion]
spk_ttyio_synth->read_buff_add(cp[i]);
^~
drivers/staging/speakup/spk_ttyio.c:82:35: note: expected 'u_char * {aka unsigned char *}' but argument is of type 'unsigned char'
vim +120 drivers/staging/speakup/serialio.c
c6e3fd22cd5383 William Hubbs 2010-10-07 111
c6e3fd22cd5383 William Hubbs 2010-10-07 112 static irqreturn_t synth_readbuf_handler(int irq, void *dev_id)
c6e3fd22cd5383 William Hubbs 2010-10-07 113 {
c6e3fd22cd5383 William Hubbs 2010-10-07 114 unsigned long flags;
c6e3fd22cd5383 William Hubbs 2010-10-07 115 int c;
8e69a811068657 Domagoj Trsan 2014-09-09 116
9fb31b1abdabab William Hubbs 2013-05-13 117 spin_lock_irqsave(&speakup_info.spinlock, flags);
c6e3fd22cd5383 William Hubbs 2010-10-07 118 while (inb_p(speakup_info.port_tts + UART_LSR) & UART_LSR_DR) {
c6e3fd22cd5383 William Hubbs 2010-10-07 119 c = inb_p(speakup_info.port_tts + UART_RX);
c6e3fd22cd5383 William Hubbs 2010-10-07 @120 synth->read_buff_add((u_char)c);
c6e3fd22cd5383 William Hubbs 2010-10-07 121 }
9fb31b1abdabab William Hubbs 2013-05-13 122 spin_unlock_irqrestore(&speakup_info.spinlock, flags);
c6e3fd22cd5383 William Hubbs 2010-10-07 123 return IRQ_HANDLED;
c6e3fd22cd5383 William Hubbs 2010-10-07 124 }
c6e3fd22cd5383 William Hubbs 2010-10-07 125
:::::: The code at line 120 was first introduced by commit
:::::: c6e3fd22cd538365bfeb82997d5b89562e077d42 Staging: add speakup to the staging directory
:::::: TO: William Hubbs <w.d.hubbs@gmail.com>
:::::: CC: Greg Kroah-Hartman <gregkh@suse.de>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69518 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue
2019-08-17 6:54 [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue Matthew Hanzelik
2019-08-17 7:00 ` Greg KH
2019-08-17 17:44 ` kbuild test robot
@ 2019-08-27 13:19 ` kbuild test robot
2 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2019-08-27 13:19 UTC (permalink / raw)
To: Matthew Hanzelik
Cc: kbuild-all, w.d.hubbs, devel, Matthew Hanzelik, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 4841 bytes --]
Hi Matthew,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190827]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Matthew-Hanzelik/Staging-speakup-spk_types-fixed-an-unnamed-parameter-style-issue/20190817-235230
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/staging/speakup/speakup_dectlk.c:132:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.read_buff_add = read_buff_add,
^~~~~~~~~~~~~
drivers/staging/speakup/speakup_dectlk.c:132:19: note: (near initialization for 'synth_dectlk.read_buff_add')
cc1: some warnings being treated as errors
--
>> drivers/staging/speakup/speakup_decext.c:126:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.read_buff_add = read_buff_add,
^~~~~~~~~~~~~
drivers/staging/speakup/speakup_decext.c:126:19: note: (near initialization for 'synth_decext.read_buff_add')
cc1: some warnings being treated as errors
vim +132 drivers/staging/speakup/speakup_dectlk.c
c6e3fd22cd5383 William Hubbs 2010-10-07 106
c6e3fd22cd5383 William Hubbs 2010-10-07 107 static struct spk_synth synth_dectlk = {
c6e3fd22cd5383 William Hubbs 2010-10-07 108 .name = "dectlk",
c6e3fd22cd5383 William Hubbs 2010-10-07 109 .version = DRV_VERSION,
c6e3fd22cd5383 William Hubbs 2010-10-07 110 .long_name = "Dectalk Express",
c6e3fd22cd5383 William Hubbs 2010-10-07 111 .init = "[:error sp :name paul :rate 180 :tsr off] ",
c6e3fd22cd5383 William Hubbs 2010-10-07 112 .procspeech = PROCSPEECH,
c6e3fd22cd5383 William Hubbs 2010-10-07 113 .clear = SYNTH_CLEAR,
c6e3fd22cd5383 William Hubbs 2010-10-07 114 .delay = 500,
c6e3fd22cd5383 William Hubbs 2010-10-07 115 .trigger = 50,
c6e3fd22cd5383 William Hubbs 2010-10-07 116 .jiffies = 50,
c6e3fd22cd5383 William Hubbs 2010-10-07 117 .full = 40000,
8a21ff775f5654 Okash Khawaja 2017-06-25 118 .dev_name = SYNTH_DEFAULT_DEV,
c6e3fd22cd5383 William Hubbs 2010-10-07 119 .startup = SYNTH_START,
c6e3fd22cd5383 William Hubbs 2010-10-07 120 .checkval = SYNTH_CHECK,
c6e3fd22cd5383 William Hubbs 2010-10-07 121 .vars = vars,
c6e3fd22cd5383 William Hubbs 2010-10-07 122 .default_pitch = ap_defaults,
c6e3fd22cd5383 William Hubbs 2010-10-07 123 .default_vol = g5_defaults,
470790eefede39 Okash Khawaja 2017-05-15 124 .io_ops = &spk_ttyio_ops,
470790eefede39 Okash Khawaja 2017-05-15 125 .probe = spk_ttyio_synth_probe,
470790eefede39 Okash Khawaja 2017-05-15 126 .release = spk_ttyio_release,
470790eefede39 Okash Khawaja 2017-05-15 127 .synth_immediate = spk_ttyio_synth_immediate,
c6e3fd22cd5383 William Hubbs 2010-10-07 128 .catch_up = do_catch_up,
c6e3fd22cd5383 William Hubbs 2010-10-07 129 .flush = synth_flush,
c6e3fd22cd5383 William Hubbs 2010-10-07 130 .is_alive = spk_synth_is_alive_restart,
c6e3fd22cd5383 William Hubbs 2010-10-07 131 .synth_adjust = NULL,
c6e3fd22cd5383 William Hubbs 2010-10-07 @132 .read_buff_add = read_buff_add,
c6e3fd22cd5383 William Hubbs 2010-10-07 133 .get_index = get_index,
c6e3fd22cd5383 William Hubbs 2010-10-07 134 .indexing = {
c6e3fd22cd5383 William Hubbs 2010-10-07 135 .command = "[:in re %d ] ",
c6e3fd22cd5383 William Hubbs 2010-10-07 136 .lowindex = 1,
c6e3fd22cd5383 William Hubbs 2010-10-07 137 .highindex = 8,
c6e3fd22cd5383 William Hubbs 2010-10-07 138 .currindex = 1,
c6e3fd22cd5383 William Hubbs 2010-10-07 139 },
c6e3fd22cd5383 William Hubbs 2010-10-07 140 .attributes = {
c6e3fd22cd5383 William Hubbs 2010-10-07 141 .attrs = synth_attrs,
c6e3fd22cd5383 William Hubbs 2010-10-07 142 .name = "dectlk",
c6e3fd22cd5383 William Hubbs 2010-10-07 143 },
c6e3fd22cd5383 William Hubbs 2010-10-07 144 };
c6e3fd22cd5383 William Hubbs 2010-10-07 145
:::::: The code at line 132 was first introduced by commit
:::::: c6e3fd22cd538365bfeb82997d5b89562e077d42 Staging: add speakup to the staging directory
:::::: TO: William Hubbs <w.d.hubbs@gmail.com>
:::::: CC: Greg Kroah-Hartman <gregkh@suse.de>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49768 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread