From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E428C3A59B for ; Mon, 19 Aug 2019 07:51:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 515602082C for ; Mon, 19 Aug 2019 07:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566201114; bh=2/vZ0TTiRM4QnAl22MZxwHQZvlNisoqFM1RJui0gC4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XnPaPePedzF6Sah19p5VBaNZRLuG/fVkZCeagR+YiiBJBhs8k52P9IGlDvSwfxSen sBMTPOlHuON/W4P89+xSRlIYtFaXxCF6sjl0Hq1KAQ0sIo2EFfBKAV1iHqu+A1v0/l KYDIvT6kHrgekIruc/qd+KnIq7YGC2Yu9h7Qa3M4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbfHSHvx (ORCPT ); Mon, 19 Aug 2019 03:51:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:36412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbfHSHvx (ORCPT ); Mon, 19 Aug 2019 03:51:53 -0400 Received: from X250 (37.80-203-192.nextgentel.com [80.203.192.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ECFAB2184E; Mon, 19 Aug 2019 07:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566201112; bh=2/vZ0TTiRM4QnAl22MZxwHQZvlNisoqFM1RJui0gC4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0B1qKbNH+o4DMmEwui7F3RpwvGKKc9/Lw1t8PYcSpKx+hDIRkEgWovjezQ+ySixZ/ QlBIW8TQ7LQvIY7a1K2wavjZJ6C7W3CYncb8leNxGC7DVdI+Fm1U9JGu2QaA1rjpBO 388CHZGw5plMGz82kCVv/3w3MilzMWp+3Y/3YkGU= Date: Mon, 19 Aug 2019 09:51:40 +0200 From: Shawn Guo To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: linux-kernel@vger.kernel.org, Russell King , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kate Stewart , Greg Kroah-Hartman , Thomas Gleixner , Leonard Crestez , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: imx: stop adjusting ar8031 phy tx delay Message-ID: <20190819075139.GF5999@X250> References: <20190809031256.3594-1-git@andred.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190809031256.3594-1-git@andred.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 09, 2019 at 04:12:56AM +0100, André Draszik wrote: > Recent changes to the Atheros at803x driver cause > the approach taken here to stop working because > commit 6d4cd041f0af > ("net: phy: at803x: disable delay only for RGMII mode") > and commit cd28d1d6e52e > ("net: phy: at803x: Disable phy delay for RGMII mode") > fix the AR8031 driver to configure the phy's (RX/TX) > delays as per the 'phy-mode' in the device tree. > > In particular, the phy tx (and rx) delays are updated > again as per the 'phy-mode' *after* the code in here > runs. > > Things worked before above commits, because the AR8031 > comes out of reset with RX delay enabled, and the > at803x driver didn't touch the delay configuration at > all when "rgmii" mode was selected. > > It appears the code in here tries to make device > trees work that incorrectly specify "rgmii", but > that can't work any more and it is imperative since > above commits to have the phy-mode configured > correctly in the device tree. > > I suspect there are a few imx7d based boards using > the ar8031 phy and phy-mode = "rgmii", but given I > don't know which ones exactly, I am not in a > position to update the respective device trees. > > Hence this patch is simply removing the superfluous > code from the imx7d initialisation. An alternative > could be to add a warning instead, but that would > penalize all boards that have been updated already. > > Signed-off-by: André Draszik > CC: Russell King > CC: Shawn Guo > CC: Sascha Hauer > CC: Pengutronix Kernel Team > CC: Fabio Estevam > CC: NXP Linux Team > CC: Kate Stewart > CC: Greg Kroah-Hartman > CC: Thomas Gleixner > CC: Leonard Crestez > CC: linux-arm-kernel@lists.infradead.org Applied, thanks.