From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D369C3A5A2 for ; Mon, 19 Aug 2019 12:38:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D71642086C for ; Mon, 19 Aug 2019 12:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566218322; bh=eQNahmOy+YOa70o8hxUX1/wwoHoUbdXOo6roeegsQow=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=oqMxT5Mxd6k+skrYBy3XCq0XT23DJBzTraMWJqig6YNhXknZw81DkCNlbj3zG7Ayd Jo3QvhIlacTio82RUhqFQw3A60wKsfdDtI2RrtuwBcpejvqQVAognowt1tcdjNoOIJ EMEX9wmYLdET5ukKq5Q1EZ47CaFbqK9pPrVM86ww= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727391AbfHSMil (ORCPT ); Mon, 19 Aug 2019 08:38:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:34024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbfHSMil (ORCPT ); Mon, 19 Aug 2019 08:38:41 -0400 Received: from localhost (lfbn-ncy-1-174-150.w83-194.abo.wanadoo.fr [83.194.254.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C88E02085A; Mon, 19 Aug 2019 12:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566218320; bh=eQNahmOy+YOa70o8hxUX1/wwoHoUbdXOo6roeegsQow=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cpidswUycCY0vFKSKTaIBQdWf+F18sTgCc8BYCJ2tD56TtVawYSEF8+h7Ys9LnowC hdl3hCORNQ1tZ9deitnOIl60UY0Uk31Q4jdmszcNVuNvQTK1HpSAiwSE1QSc9HyxTs DAyms2dvo5Ql8MxqTUlmiMV1JOaa0PlDR4Rm5fEM= Date: Mon, 19 Aug 2019 14:38:38 +0200 From: Frederic Weisbecker To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, rcu@vger.kernel.org, "Paul E. McKenney" Subject: Re: [PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks Message-ID: <20190819123837.GC27088@lenoir> References: <20190816025311.241257-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190816025311.241257-1-joel@joelfernandes.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 15, 2019 at 10:53:09PM -0400, Joel Fernandes (Google) wrote: > This commit fixes the issue. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/tree.c | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index 0512de9ead20..322b1b57967c 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -829,7 +829,7 @@ static __always_inline void rcu_nmi_enter_common(bool irq) > !rdp->dynticks_nmi_nesting && > rdp->rcu_urgent_qs && !rdp->rcu_forced_tick) { > rdp->rcu_forced_tick = true; > - tick_dep_set_cpu(rdp->cpu, TICK_DEP_MASK_RCU); > + tick_dep_set_cpu(rdp->cpu, TICK_DEP_BIT_RCU); Did I suggest you to use the _MASK_ value? That was a bit mean. Sorry for all that lost debugging time :-(