From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B14C3A5A0 for ; Mon, 19 Aug 2019 13:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06D8A2085A for ; Mon, 19 Aug 2019 13:27:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="zyzsLyF9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727656AbfHSN1g (ORCPT ); Mon, 19 Aug 2019 09:27:36 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:41532 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727391AbfHSN1g (ORCPT ); Mon, 19 Aug 2019 09:27:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UyJXh5G4lCxvf58D0NEKhzaJuQrSIL3MtD7HQ1EPJX8=; b=zyzsLyF90TE2rKMmt9lxn5jqDK DOFTgMMkek8YBO0CRR/+2+DzHpUyu6E1G1Wqr1JeMzOraCl3JsxZQD0vuCGoL1u8AsZvq+x58UGMZ DWPCqJSF7jTFJWVF+sGluX7dqSOnKDQB8q8v1wWHUawe/0zgg/tzY76PpXePhT+9+7OQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hzhh7-00060z-7Y; Mon, 19 Aug 2019 15:27:33 +0200 Date: Mon, 19 Aug 2019 15:27:33 +0200 From: Andrew Lunn To: Hubert Feurstein Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Cochran , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" Subject: Re: [PATCH net-next 2/3] net: dsa: mv88e6xxx: extend PTP gettime function to read system clock Message-ID: <20190819132733.GE8981@lunn.ch> References: <20190816163157.25314-1-h.feurstein@gmail.com> <20190816163157.25314-3-h.feurstein@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190816163157.25314-3-h.feurstein@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -45,7 +45,8 @@ static int mv88e6xxx_smi_direct_write(struct mv88e6xxx_chip *chip, > { > int ret; > > - ret = mdiobus_write_nested(chip->bus, dev, reg, data); > + ret = mdiobus_write_sts_nested(chip->bus, dev, reg, data, > + chip->ptp_sts); > if (ret < 0) > return ret; > Please also make a similar change to mv88e6xxx_smi_indirect_write(). The last write in that function should be timestamped. Vivien, please could you think about these changes with respect to RMU. We probably want to skip the RMU in this case, so we get slow but uniform jitter, vs fast and unpredictable jitter from using the RMU. Thanks Andrew