From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8364FC3A5A0 for ; Mon, 19 Aug 2019 14:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 418B52082A for ; Mon, 19 Aug 2019 14:56:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="A+qR5RmW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727464AbfHSO4y (ORCPT ); Mon, 19 Aug 2019 10:56:54 -0400 Received: from mail.skyhub.de ([5.9.137.197]:34410 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbfHSO4y (ORCPT ); Mon, 19 Aug 2019 10:56:54 -0400 Received: from zn.tnic (p200300EC2F04B7003923E3AC7BEA9973.dip0.t-ipconnect.de [IPv6:2003:ec:2f04:b700:3923:e3ac:7bea:9973]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D35141EC04CD; Mon, 19 Aug 2019 16:56:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1566226612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=uL8XD/CJYv4Vc8MNOkuxTsIsj/5UNIGjzcyVsd0lTGg=; b=A+qR5RmWScF4AslQ7okxH81RwFDlSuXu1WxiWJf6A0nYWawlqdCtTeYgPdOdtP8QHG5QAE ujTTrZYZUpOiM3BSxFZaJtLUYzK2laSsQ1ssD+QDCh62P+fkbSuyscZeNmJCzxkM5+L6ZB JxjbfmJOQaT1NwGM4JGDHZ3kzJX0xrc= Date: Mon, 19 Aug 2019 16:56:52 +0200 From: Borislav Petkov To: Jiri Slaby Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 10/28] x86/asm/entry: annotate interrupt symbols properly Message-ID: <20190819145652.GC4522@zn.tnic> References: <20190808103854.6192-1-jslaby@suse.cz> <20190808103854.6192-11-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190808103854.6192-11-jslaby@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 08, 2019 at 12:38:36PM +0200, Jiri Slaby wrote: > * annotate functions properly by SYM_CODE_START, SYM_CODE_START_LOCAL* > and SYM_CODE_END -- these are not C-like functions, so we have to > annotate them using CODE. > * use SYM_INNER_LABEL* for labels being in the middle of other functions > > [v4] alignments preserved > > Signed-off-by: Jiri Slaby > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: > --- > arch/x86/entry/entry_32.S | 28 ++++++++++++++-------------- > arch/x86/entry/entry_64.S | 13 ++++++------- > 2 files changed, 20 insertions(+), 21 deletions(-) Here again some of the symbols are used only in a single complilation unit and thus made local symbols by prepending their name with ".L" so that they don't pollute the symbol table. Pls do that for all symbols you're touching, while you're at it. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.