From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81DF4C3A589 for ; Tue, 20 Aug 2019 05:08:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56E6F2087E for ; Tue, 20 Aug 2019 05:08:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yoStAr6y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729245AbfHTFID (ORCPT ); Tue, 20 Aug 2019 01:08:03 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:43662 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729124AbfHTFIC (ORCPT ); Tue, 20 Aug 2019 01:08:02 -0400 Received: by mail-pl1-f194.google.com with SMTP id 4so2115757pld.10 for ; Mon, 19 Aug 2019 22:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=X0RALe/oCLLbFYKOz+mFdGYTmz4Bg6uXMn9I91aUmVQ=; b=yoStAr6ymurtV2ikx4ft95lv5WFYdKXAOmLgGdPFwmAIKWHkr3/vRYJ6g6fMOGVnvf zBisfnxERsNRNYh51te6OMltVF+PeFfr0P/2MvaO77Kp6K0xraqJAlCm+d/hHE4jfBl+ ZYnTrek4iwdH9zr7nZSK8L+FFYpvgVjVDlsSBKW5QGeIOv5aEe2FGKj5mxqV+4VS14O/ buL2/RKNI2B8mu6F1e+c+5Gmw4yMgOs4nP4rSdeNLEyxWOWOjiN7zmOvopCpjuYqmrFu E8TMwa9NxV2zMdXcQGf1CI78FM7zGMkd7R3tnkMXT15CZDcWr/8TLvVmQ8ZKMh02Lrm9 LRyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=X0RALe/oCLLbFYKOz+mFdGYTmz4Bg6uXMn9I91aUmVQ=; b=tzMIbeZCXJith9cig2SpCkYGe5SRnJ8cFu0YW8fBG2+IHO2XMsa52r3AunLVAyb4OH HxsFCUbAO5OGPve0yeBHWY7njhGo1Ge1+hHnpXDQXEyM3gKwfn97Zqjfyy+/5DWF9Oa7 JC6t4SZmK4QUNtkr3uiPY0yjt1zdWodXlFVbp6XZRDZxp/8d2UH/vYaIp/0nydIdc+w/ 1f2w7DjrxvOHV5WXcjqO9YM3z+VGw7vV1D83Bt75t6QgZg0kHFw5WEcPfr//0OisQT2Y ybdcyFTlyEFj4qXtwEPPLQV+8jUohPFiQPFW1JLHjjyBfEtijBxg7KPuAu6mc5KR/YF2 jx0Q== X-Gm-Message-State: APjAAAXuBuFqjzzvjysVXMAT9nTElt2vxMdIOrYdQPmCl4w+fiYEY3S5 9jaG2lfXELiAGKfWzzRgFP7jnQ== X-Google-Smtp-Source: APXvYqxnbtpYfHf4DI7CzWwEfyLBSbbPObmlVar90y00ULixju4JrpyOcJKYoSXXPw0x1oXHjOOnAQ== X-Received: by 2002:a17:902:288b:: with SMTP id f11mr42667plb.13.1566277681833; Mon, 19 Aug 2019 22:08:01 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id y68sm8288666pfy.25.2019.08.19.22.08.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2019 22:08:01 -0700 (PDT) Date: Mon, 19 Aug 2019 22:09:44 -0700 From: Bjorn Andersson To: Vinod Koul Cc: Stephen Boyd , linux-arm-msm@vger.kernel.org, Andy Gross , Michael Turquette , Rob Herring , Mark Rutland , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] clk: qcom: clk-rpmh: Add support for SM8150 Message-ID: <20190820050944.GL26807@tuxbook-pro> References: <20190819073947.17258-1-vkoul@kernel.org> <20190819073947.17258-5-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190819073947.17258-5-vkoul@kernel.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 19 Aug 00:39 PDT 2019, Vinod Koul wrote: > Add support for rpmh clocks found in SM8150 > > Signed-off-by: Vinod Koul > --- > drivers/clk/qcom/clk-rpmh.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c > index 16d689e5bb3c..3b304a3fb5c9 100644 > --- a/drivers/clk/qcom/clk-rpmh.c > +++ b/drivers/clk/qcom/clk-rpmh.c > @@ -374,6 +374,32 @@ static const struct clk_rpmh_desc clk_rpmh_sdm845 = { > .num_clks = ARRAY_SIZE(sdm845_rpmh_clocks), > }; > > +DEFINE_CLK_RPMH_ARC(sm8150, bi_tcxo, bi_tcxo_ao, "xo.lvl", 0x3, 2); > +DEFINE_CLK_RPMH_VRM(sm8150, ln_bb_clk2, ln_bb_clk2_ao, "lnbclka2", 2); > +DEFINE_CLK_RPMH_VRM(sm8150, ln_bb_clk3, ln_bb_clk3_ao, "lnbclka3", 2); > +DEFINE_CLK_RPMH_VRM(sm8150, rf_clk1, rf_clk1_ao, "rfclka1", 1); > +DEFINE_CLK_RPMH_VRM(sm8150, rf_clk2, rf_clk2_ao, "rfclka2", 1); > +DEFINE_CLK_RPMH_VRM(sm8150, rf_clk3, rf_clk3_ao, "rfclka3", 1); > + > +static struct clk_hw *sm8150_rpmh_clocks[] = { > + [RPMH_CXO_CLK] = &sm8150_bi_tcxo.hw, > + [RPMH_CXO_CLK_A] = &sm8150_bi_tcxo_ao.hw, > + [RPMH_LN_BB_CLK2] = &sm8150_ln_bb_clk2.hw, > + [RPMH_LN_BB_CLK2_A] = &sm8150_ln_bb_clk2_ao.hw, > + [RPMH_LN_BB_CLK3] = &sm8150_ln_bb_clk3.hw, > + [RPMH_LN_BB_CLK3_A] = &sm8150_ln_bb_clk3_ao.hw, > + [RPMH_RF_CLK1] = &sm8150_rf_clk1.hw, > + [RPMH_RF_CLK1_A] = &sm8150_rf_clk1_ao.hw, > + [RPMH_RF_CLK2] = &sm8150_rf_clk2.hw, > + [RPMH_RF_CLK2_A] = &sm8150_rf_clk2_ao.hw, > + [RPMH_RF_CLK3] = &sm8150_rf_clk3.hw, > + [RPMH_RF_CLK3_A] = &sm8150_rf_clk3_ao.hw, > +}; > + > +static const struct clk_rpmh_desc clk_rpmh_sm8150 = { > + .clks = sm8150_rpmh_clocks, > + .num_clks = ARRAY_SIZE(sm8150_rpmh_clocks), > +}; Maybe an empty line here? > static struct clk_hw *of_clk_rpmh_hw_get(struct of_phandle_args *clkspec, > void *data) > { > @@ -453,6 +479,7 @@ static int clk_rpmh_probe(struct platform_device *pdev) > > static const struct of_device_id clk_rpmh_match_table[] = { > { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, > + { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150}, > { } > }; > MODULE_DEVICE_TABLE(of, clk_rpmh_match_table); Reviewed-by: Bjorn Andersson Regards, Bjorn > -- > 2.20.1 >