Re: [PATCH v2 4/4] clk: qcom: clk-rpmh: Add support for SM8150

Vinod Koul
2019-08-22T14:02:48Z

On 19-08-19, 22:09, Bjorn Andersson wrote:
> On Mon 19 Aug 00:39 PDT 2019, Vinod Koul wrote:
> > +static const struct clk_rpmh_desc clk_rpmh_sm8150 = {
> > + .clks = sm8150_rpmh_clocks,
> > + .num_clks = ARRAY_SIZE(sm8150_rpmh_clocks),
> > +};
>
> Maybe an empty line here?

Sounds better

>
> > static struct clk_hw *of_clk_rpmh_hw_get(struct of_phandle_args *clkspec,
> > void *data)
> > {
> > @@ -453,6 +479,7 @@ static int clk_rpmh_probe(struct platform_device *pdev)
> >
> > static const struct of_device_id clk_rpmh_match_table[] = {
> > { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845},
> > + { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150},
> > { }
> > };
> > MODULE_DEVICE_TABLE(of, clk_rpmh_match_table);
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Thanks for the review, will send an update.

--
~Vinod