From: Daniel Vetter <daniel@ffwll.ch>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Togorean, Bogdan" <Bogdan.Togorean@analog.com>,
"Laurent.pinchart@ideasonboard.com"
<Laurent.pinchart@ideasonboard.com>,
"a.hajda@samsung.com" <a.hajda@samsung.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"allison@lohutok.net" <allison@lohutok.net>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"matt.redfearn@thinci.com" <matt.redfearn@thinci.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v2 2/2] drm: bridge: adv7511: Add support for ADV7535
Date: Tue, 20 Aug 2019 10:53:29 +0200 [thread overview]
Message-ID: <20190820085329.GC11147@phenom.ffwll.local> (raw)
In-Reply-To: <20190819104616.GA15890@ravnborg.org>
On Mon, Aug 19, 2019 at 12:46:16PM +0200, Sam Ravnborg wrote:
> Hi Bogdan.
>
> > > > adv7533_detach_dsi(adv7511);
> > > > i2c_unregister_device(adv7511->i2c_cec);
> > > > if (adv7511->cec_clk)
> > > > @@ -1266,8 +1278,9 @@ static const struct i2c_device_id
> > > > adv7511_i2c_ids[] = {
> > > > { "adv7511", ADV7511 },
> > > > { "adv7511w", ADV7511 },
> > > > { "adv7513", ADV7511 },
> > > > -#ifdef CONFIG_DRM_I2C_ADV7533
> > > > +#ifdef CONFIG_DRM_I2C_ADV753x
> > > > { "adv7533", ADV7533 },
> > > > + { "adv7535", ADV7535 },
> > > > #endif
> > >
> > > This ifdef may not be needed??
> > > If we did not get this type we will not look it up.
> > But if we have defined in DT adv7533/5 device but
> > CONFIG_DRM_I2C_ADV753x not selected probe will fail with ENODEV. That
> > would be ok?
>
> What do we gain from this complexity in the end.
> Why not let the driver always support all variants.
>
> If this result in a simpler driver, and less choices in Kconfig
> then it is a win-win.
Yeah in general we don't Kconfig within drivers in drm to disable specific
code-paths. It's not worth the pain.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-08-20 8:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 14:16 [PATCH v2 0/2] drm: bridge: adv7511: Add support For ADV7535 Bogdan Togorean
2019-08-09 14:16 ` [PATCH v2 1/2] dt-bindings: drm: bridge: adv7511: Add ADV7535 support Bogdan Togorean
2019-08-09 14:16 ` [PATCH v2 2/2] drm: bridge: adv7511: Add support for ADV7535 Bogdan Togorean
2019-08-09 15:25 ` Sam Ravnborg
2019-08-19 8:59 ` Togorean, Bogdan
2019-08-19 10:46 ` Sam Ravnborg
2019-08-20 8:53 ` Daniel Vetter [this message]
2019-08-21 5:34 ` Togorean, Bogdan
2019-11-27 11:52 ` Schrempf Frieder
2019-11-27 14:22 ` Togorean, Bogdan
2019-11-27 14:46 ` Schrempf Frieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820085329.GC11147@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Bogdan.Togorean@analog.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=allison@lohutok.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.redfearn@thinci.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox