From: Peter Zijlstra <peterz@infradead.org>
To: c00423981 <caomeng5@huawei.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpustat: print watchdog time and statistics of soft and hard interrupts in soft lockup scenes
Date: Tue, 20 Aug 2019 13:04:30 +0200 [thread overview]
Message-ID: <20190820110430.GL2332@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <60319e82-3c2b-ff24-4ba7-4d58048130ff@huawei.com>
On Mon, Aug 19, 2019 at 03:12:24PM +0800, c00423981 wrote:
> +static u64 cpustat_curr_cputime(int cpu, int index)
> +{
> + u64 time;
> +
> + if (index == CPUTIME_IDLE)
> + time = get_idle_time(cpu);
> + else if (index == CPUTIME_IOWAIT)
> + time = get_iowait_time(cpu);
NAK; don't add new users of this terminally broken interface.
next prev parent reply other threads:[~2019-08-20 11:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 7:12 [PATCH] cpustat: print watchdog time and statistics of soft and hard interrupts in soft lockup scenes c00423981
2019-08-20 11:04 ` Peter Zijlstra [this message]
2019-08-21 8:26 ` c00423981
2019-08-21 10:46 ` Peter Zijlstra
2019-08-22 11:58 ` [PATCH V2] " c00423981
2019-08-22 16:14 ` Peter Zijlstra
2019-08-23 7:26 ` c00423981
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820110430.GL2332@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=caomeng5@huawei.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox