From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E57C6C3A589 for ; Tue, 20 Aug 2019 11:17:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B668B2070B for ; Tue, 20 Aug 2019 11:17:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p2PVwOPj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729768AbfHTLRX (ORCPT ); Tue, 20 Aug 2019 07:17:23 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:42908 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728414AbfHTLRX (ORCPT ); Tue, 20 Aug 2019 07:17:23 -0400 Received: by mail-wr1-f66.google.com with SMTP id b16so11965616wrq.9; Tue, 20 Aug 2019 04:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bXwvv3+bDP0X0rOQDdFLtwDDPymGiUwzjcOJ0HsnIoE=; b=p2PVwOPjW3GPoH2xQ0T6VFrvCH9Q37bASBLkU2zRM6QatFv2y8rptDncRm65Zx1Zza 4J5c/sPWUjAFj5bTNwwcb2Qc4YgziJqHajkQAaqpXim1EueyoAZMjNFQu/KhrCvpjWFJ MR1CJ5jE1dQT4oEtygM2Tf5KmbArrSc3pAKXOG7xBWokFCsYRGOUWbWfvjziz0ZafL2e tKG4itMnTKNHHlKl8v5aza5guqMQN/8v1rVDXpstpIOPLtqYfwkLtxgOJ0HyGNmsIPBD OnDiGXmGUA7aH+AieNFNTdH0S5HqFb46zEXfC98fbF5JP0VYSHbJ9weiSmzCcrNNAqBb gzIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=bXwvv3+bDP0X0rOQDdFLtwDDPymGiUwzjcOJ0HsnIoE=; b=hBAVGpHraNcB5I6zQojRBWoICXBFPrKyS3SH5W3+zGNTdG4wFR5VX4LoC9mcKT2yd8 kmooaRo3XjfdxhZt5oqlXoGM8XknYOgW1VoDPtuN558ZItuUK34OCjHQ5Nk2x3rzu0ik cuUKfpcnR+XoYgEHcSCv9tiHyjnak8SKFJ+xLbuzxZIrhAsa4oc61A0A6GaE0sggfmyO 1v97dPad8H4kvYGeOUhJovhM/HqUdPJRaO0Kel1h0QM22/TM3NNkUBH8hgyV/M0HOzA+ RvH8bpFzXIR5rAbEhyvKsFHb2KABlgexTC80u7h+lClvymgIV17fBe8q1goA9xBWvE6M ZQjQ== X-Gm-Message-State: APjAAAVkOryMGhAs0JZ6Fa4HIU08bI7jEm5IHX7yjluhe/PaWKfp/Pa9 o06m6DPDeItox9iNoxBqclg= X-Google-Smtp-Source: APXvYqzoIgxGymU2wbx/jK3Z3oup/G3SR810t/fO7KbuQzxb0XC8CA0c8AA9b4NaBwg25QISd1IpkA== X-Received: by 2002:adf:f48d:: with SMTP id l13mr35550680wro.190.1566299840925; Tue, 20 Aug 2019 04:17:20 -0700 (PDT) Received: from pali ([2a02:2b88:2:1::5cc6:2f]) by smtp.gmail.com with ESMTPSA id 91sm54808747wrp.3.2019.08.20.04.17.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Aug 2019 04:17:20 -0700 (PDT) Date: Tue, 20 Aug 2019 13:17:19 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: "Enrico Weigelt, metux IT consult" Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net Subject: Re: [PATCH 2/2] drivers: input: mouse: alps: drop unneeded likely() call around IS_ERR() Message-ID: <20190820111719.7blyk5jstgwde2ae@pali> References: <1566298572-12409-1-git-send-email-info@metux.net> <1566298572-12409-2-git-send-email-info@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1566298572-12409-2-git-send-email-info@metux.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 20 August 2019 12:56:12 Enrico Weigelt, metux IT consult wrote: > From: Enrico Weigelt > > IS_ERR() already calls unlikely(), so this extra unlikely() call > around IS_ERR() is not needed. > > Signed-off-by: Enrico Weigelt > --- > drivers/input/mouse/alps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > index 34700ed..ed16614 100644 > --- a/drivers/input/mouse/alps.c > +++ b/drivers/input/mouse/alps.c > @@ -1476,7 +1476,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse, > /* On V2 devices the DualPoint Stick reports bare packets */ > dev = priv->dev2; > dev2 = psmouse->dev; > - } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) { > + } else if (IS_ERR_OR_NULL(priv->dev3)) { > /* Register dev3 mouse if we received PS/2 packet first time */ > if (!IS_ERR(priv->dev3)) > psmouse_queue_work(psmouse, &priv->dev3_register_work, Hello! Two months ago I already saw this patch. See discussion: https://patchwork.kernel.org/patch/10977099/ -- Pali Rohár pali.rohar@gmail.com