From: Keith Busch <kbusch@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: Ming Lei <tom.leiming@gmail.com>,
"longli@linuxonhyperv.com" <longli@linuxonhyperv.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"Busch, Keith" <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme <linux-nvme@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Long Li <longli@microsoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
chenxiang <chenxiang66@hisilicon.com>
Subject: Re: [PATCH 0/3] fix interrupt swamp in NVMe
Date: Tue, 20 Aug 2019 09:05:11 -0600 [thread overview]
Message-ID: <20190820150511.GD11202@localhost.localdomain> (raw)
In-Reply-To: <fd7d6101-37f4-2d34-f2f7-cfeade610278@huawei.com>
On Tue, Aug 20, 2019 at 01:59:32AM -0700, John Garry wrote:
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index e8f7f179bf77..cb483a055512 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -966,9 +966,13 @@ irq_thread_check_affinity(struct irq_desc *desc,
> struct irqaction *action)
> * mask pointer. For CPU_MASK_OFFSTACK=n this is optimized out.
> */
> if (cpumask_available(desc->irq_common_data.affinity)) {
> + struct irq_data *irq_data = &desc->irq_data;
> const struct cpumask *m;
>
> - m = irq_data_get_effective_affinity_mask(&desc->irq_data);
> + if (action->flags & IRQF_IRQ_AFFINITY)
> + m = desc->irq_common_data.affinity;
> + else
> + m = irq_data_get_effective_affinity_mask(irq_data);
> cpumask_copy(mask, m);
> } else {
> valid = false;
> --
> 2.17.1
>
> As Ming mentioned in that same thread, we could even make this policy
> for managed interrupts.
Ack, I really like this option!
next prev parent reply other threads:[~2019-08-20 15:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 6:14 [PATCH 0/3] fix interrupt swamp in NVMe longli
2019-08-20 6:14 ` [PATCH 1/3] sched: define a function to report the number of context switches on a CPU longli
2019-08-20 9:38 ` Peter Zijlstra
2019-08-21 8:20 ` Long Li
2019-08-21 10:34 ` Peter Zijlstra
2019-08-20 9:39 ` Peter Zijlstra
2019-08-20 6:14 ` [PATCH 2/3] sched: export idle_cpu() longli
2019-08-20 6:14 ` [PATCH 3/3] nvme: complete request in work queue on CPU with flooded interrupts longli
2019-08-20 9:52 ` Peter Zijlstra
2019-08-21 8:37 ` Long Li
2019-08-21 10:35 ` Peter Zijlstra
2019-08-20 17:33 ` Sagi Grimberg
2019-08-21 8:39 ` Long Li
2019-08-21 17:36 ` Long Li
2019-08-21 21:54 ` Sagi Grimberg
2019-08-24 0:13 ` Long Li
2019-08-23 3:21 ` Ming Lei
2019-08-24 0:27 ` Long Li
2019-08-24 12:55 ` Ming Lei
2019-08-20 8:25 ` [PATCH 0/3] fix interrupt swamp in NVMe Ming Lei
2019-08-20 8:59 ` John Garry
2019-08-20 15:05 ` Keith Busch [this message]
2019-08-21 7:47 ` Long Li
2019-08-21 9:44 ` Ming Lei
2019-08-21 10:03 ` John Garry
2019-08-21 16:27 ` Long Li
2019-08-22 1:33 ` Ming Lei
2019-08-22 2:00 ` Keith Busch
2019-08-22 2:23 ` Ming Lei
2019-08-22 9:48 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820150511.GD11202@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=chenxiang66@hisilicon.com \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).