From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BC1C3A59D for ; Tue, 20 Aug 2019 16:30:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D6A922DD6 for ; Tue, 20 Aug 2019 16:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566318620; bh=KymnAe727ILy87L8EAf1U8mLv+nBZNNdGy5iODp5MOM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YqwWP9GROTC4gMjdLsNckKQMxuxuAexrWwwk3Z500K8Jbr3nUvN19klFRI/ZlMpgt gNxjd77PJS6GMZDvhdA45SQlXcW4xTE03zeleFvcGXJNiyo9dzTG47ixowkjn77oCm CAcyf9T5q1eIpI+QYZ8PhQKjWZnBvwuhCzSX7mb0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730473AbfHTQaT (ORCPT ); Tue, 20 Aug 2019 12:30:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:54442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728344AbfHTQaT (ORCPT ); Tue, 20 Aug 2019 12:30:19 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9C9CD22CE3; Tue, 20 Aug 2019 16:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566318617; bh=KymnAe727ILy87L8EAf1U8mLv+nBZNNdGy5iODp5MOM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eDe8D8mOkxt6Kz0TpZGa8O/1CtWzHWy0JCS9J71kHEp4zEqh4FTOMlBS58n/d2Agm IV1vDDP+f1MMVB2ItdJkHXGpcR8dZvNBxSLPp/bvt4FA6OIsDYcacj62MjHGmr2TkB 3yctVmNKKcLVNmORtLwVOdDuVYwVJLTXKgrE91ek= Date: Tue, 20 Aug 2019 09:30:17 -0700 From: Greg Kroah-Hartman To: Michael Ellerman Cc: Alastair D'Silva , alastair@d-silva.org, stable@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Allison Randal , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB Message-ID: <20190820163017.GG8214@kroah.com> References: <20190815045543.16325-1-alastair@au1.ibm.com> <20190815071924.GA26670@kroah.com> <87mug97uo1.fsf@concordia.ellerman.id.au> <20190816071412.GF1368@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190816071412.GF1368@kroah.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2019 at 09:14:12AM +0200, Greg Kroah-Hartman wrote: > On Fri, Aug 16, 2019 at 11:42:22AM +1000, Michael Ellerman wrote: > > Greg Kroah-Hartman writes: > > > On Thu, Aug 15, 2019 at 02:55:42PM +1000, Alastair D'Silva wrote: > > >> From: Alastair D'Silva > > >> > > >> Heads Up: This patch cannot be submitted to Linus's tree, as the affected > > >> assembler functions have already been converted to C. > > > > That was done in upstream commit: > > > > 22e9c88d486a ("powerpc/64: reuse PPC32 static inline flush_dcache_range()") > > > > Which is a larger change that we don't want to backport. This patch is a > > minimal fix for stable trees. > > > > > > >> When calling flush_(inval_)dcache_range with a size >4GB, we were masking > > >> off the upper 32 bits, so we would incorrectly flush a range smaller > > >> than intended. > > >> > > >> This patch replaces the 32 bit shifts with 64 bit ones, so that > > >> the full size is accounted for. > > >> > > >> Signed-off-by: Alastair D'Silva > > >> --- > > >> arch/powerpc/kernel/misc_64.S | 4 ++-- > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Acked-by: Michael Ellerman > > > > > > > > > > > This is not the correct way to submit patches for inclusion in the > > > stable kernel tree. Please read: > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > for how to do this properly. > > > > > > > > > > Hi Greg, > > > > This is "option 3", submit the patch directly, and the patch "deviates > > from the original upstream patch" because the upstream patch was a > > wholesale conversion from asm to C. > > > > This patch applies cleanly to v4.14 and v4.19. > > > > The change log should have mentioned which upstream patch it is not a > > backport of, is there anything else we should have done differently to > > avoid the formletter bot :) > > That is exactly what you should have done. It needs to be VERY explicit > as to why this is being submitted different from what upstream did, and > to what trees it needs to go to and who is going to be responsible for > when it breaks. And it will break :) And it needs to be done before I can apply it, I've dropped this thread from my queue now. thanks, greg k-h