From: Gao Xiang <gaoxiang25@huawei.com>
To: Joe Perches <joe@perches.com>
Cc: Caitlyn <caitlynannefinn@gmail.com>, Chao Yu <yuchao0@huawei.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Tobin C . Harding" <me@tobin.cc>, <linux-erofs@lists.ozlabs.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements.
Date: Wed, 21 Aug 2019 10:31:22 +0800 [thread overview]
Message-ID: <20190821023122.GA159802@architecture4> (raw)
In-Reply-To: <7aaca457a3d3feb951082d0659eec568a908971f.camel@perches.com>
On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote:
> On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote:
> > Balanced braces to fix some checkpath warnings in inode.c and
> > unzip_vle.c
> []
> > diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c
> []
> > @@ -915,21 +915,21 @@ static int z_erofs_vle_unzip(struct super_block *sb,
> > mutex_lock(&work->lock);
> > nr_pages = work->nr_pages;
> >
> > - if (likely(nr_pages <= Z_EROFS_VLE_VMAP_ONSTACK_PAGES))
> > + if (likely(nr_pages <= Z_EROFS_VLE_VMAP_ONSTACK_PAGES)) {
> > pages = pages_onstack;
> > - else if (nr_pages <= Z_EROFS_VLE_VMAP_GLOBAL_PAGES &&
> > - mutex_trylock(&z_pagemap_global_lock))
> > + } else if (nr_pages <= Z_EROFS_VLE_VMAP_GLOBAL_PAGES &&
> > + mutex_trylock(&z_pagemap_global_lock)) {
>
> Extra space after tab
There is actually balanced braces in linux-next.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/erofs/zdata.c#n762
>
> > pages = z_pagemap_global;
> > - else {
> > + } else {
> > repeat:
> > pages = kvmalloc_array(nr_pages, sizeof(struct page *),
> > GFP_KERNEL);
> >
> > /* fallback to global pagemap for the lowmem scenario */
> > if (unlikely(!pages)) {
> > - if (nr_pages > Z_EROFS_VLE_VMAP_GLOBAL_PAGES)
> > + if (nr_pages > Z_EROFS_VLE_VMAP_GLOBAL_PAGES) {
> > goto repeat;
> > - else {
> > + } else {
>
> Unnecessary else
There is not the "goto repeat" in linux-next anymore.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/erofs/zdata.c#n765
Thanks,
Gao Xiang
>
> > mutex_lock(&z_pagemap_global_lock);
> > pages = z_pagemap_global;
> > }
>
>
next prev parent reply other threads:[~2019-08-21 2:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 0:18 [PATCH 0/2] Submitting my first patch series (Checkpatch fixes) Caitlyn
2019-08-21 0:18 ` [PATCH 1/2] staging/erofs/xattr.h: Fixed misaligned function arguments Caitlyn
2019-08-21 2:20 ` Greg Kroah-Hartman
2019-08-21 0:18 ` [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements Caitlyn
2019-08-21 0:40 ` Gao Xiang
2019-08-21 2:26 ` Joe Perches
2019-08-21 2:31 ` Gao Xiang [this message]
2019-08-21 15:13 ` Tobin C. Harding
2019-08-21 15:52 ` Gao Xiang
2019-08-21 20:11 ` Caitlyn Finn
2019-08-21 0:39 ` [PATCH 0/2] Submitting my first patch series (Checkpatch fixes) Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821023122.GA159802@architecture4 \
--to=gaoxiang25@huawei.com \
--cc=caitlynannefinn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox