* [PATCH] tools/power: intel-speed-select: Fix a read overflow in isst_set_tdp_level_msr()
@ 2019-08-21 7:14 Dan Carpenter
2019-08-21 16:20 ` Srinivas Pandruvada
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-08-21 7:14 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: platform-driver-x86, linux-kernel, kernel-janitors,
Andy Shevchenko
The isst_send_msr_command() function will read 8 bytes but we are
passing an address to an int (4 bytes) so it results in a read overflow.
Fixes: 3fb4f7cd472c ("tools/power/x86: A tool to validate Intel Speed Select commands")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
tools/power/x86/intel-speed-select/isst-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/power/x86/intel-speed-select/isst-core.c b/tools/power/x86/intel-speed-select/isst-core.c
index 8de4ac39a008..f724322856ed 100644
--- a/tools/power/x86/intel-speed-select/isst-core.c
+++ b/tools/power/x86/intel-speed-select/isst-core.c
@@ -190,6 +190,7 @@ int isst_get_get_trl(int cpu, int level, int avx_level, int *trl)
int isst_set_tdp_level_msr(int cpu, int tdp_level)
{
+ unsigned long long level = tdp_level;
int ret;
debug_printf("cpu: tdp_level via MSR %d\n", cpu, tdp_level);
@@ -202,8 +203,7 @@ int isst_set_tdp_level_msr(int cpu, int tdp_level)
if (tdp_level > 2)
return -1; /* invalid value */
- ret = isst_send_msr_command(cpu, 0x64b, 1,
- (unsigned long long *)&tdp_level);
+ ret = isst_send_msr_command(cpu, 0x64b, 1, &level);
if (ret)
return ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tools/power: intel-speed-select: Fix a read overflow in isst_set_tdp_level_msr()
2019-08-21 7:14 [PATCH] tools/power: intel-speed-select: Fix a read overflow in isst_set_tdp_level_msr() Dan Carpenter
@ 2019-08-21 16:20 ` Srinivas Pandruvada
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Pandruvada @ 2019-08-21 16:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: platform-driver-x86, linux-kernel, kernel-janitors,
Andy Shevchenko
On Wed, 2019-08-21 at 10:14 +0300, Dan Carpenter wrote:
> The isst_send_msr_command() function will read 8 bytes but we are
> passing an address to an int (4 bytes) so it results in a read
> overflow.
>
> Fixes: 3fb4f7cd472c ("tools/power/x86: A tool to validate Intel Speed
> Select commands")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> tools/power/x86/intel-speed-select/isst-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/x86/intel-speed-select/isst-core.c
> b/tools/power/x86/intel-speed-select/isst-core.c
> index 8de4ac39a008..f724322856ed 100644
> --- a/tools/power/x86/intel-speed-select/isst-core.c
> +++ b/tools/power/x86/intel-speed-select/isst-core.c
> @@ -190,6 +190,7 @@ int isst_get_get_trl(int cpu, int level, int
> avx_level, int *trl)
>
> int isst_set_tdp_level_msr(int cpu, int tdp_level)
> {
> + unsigned long long level = tdp_level;
> int ret;
>
> debug_printf("cpu: tdp_level via MSR %d\n", cpu, tdp_level);
> @@ -202,8 +203,7 @@ int isst_set_tdp_level_msr(int cpu, int
> tdp_level)
> if (tdp_level > 2)
> return -1; /* invalid value */
>
> - ret = isst_send_msr_command(cpu, 0x64b, 1,
> - (unsigned long long *)&tdp_level);
> + ret = isst_send_msr_command(cpu, 0x64b, 1, &level);
> if (ret)
> return ret;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-21 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-21 7:14 [PATCH] tools/power: intel-speed-select: Fix a read overflow in isst_set_tdp_level_msr() Dan Carpenter
2019-08-21 16:20 ` Srinivas Pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox