From: Peter Zijlstra <peterz@infradead.org>
To: c00423981 <caomeng5@huawei.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpustat: print watchdog time and statistics of soft and hard interrupts in soft lockup scenes
Date: Wed, 21 Aug 2019 12:46:43 +0200 [thread overview]
Message-ID: <20190821104643.GA2349@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <4eb6b499-b6b0-602a-ae89-0c1dceaa5088@huawei.com>
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
On Wed, Aug 21, 2019 at 04:26:17PM +0800, c00423981 wrote:
> Sorry, I cannot understand this problem accurately. I try to understand it and I guess what you want
> to express is that the return value type should be cputime64_t but not u64, just like as follows:
>
> +static cputime64_t cpustat_curr_cputime(int cpu, int index)
> +{
> + cputime64_t time;
> +
> + if (index == CPUTIME_IDLE)
> + time = get_idle_time(cpu);
> + else if (index == CPUTIME_IOWAIT)
> + time = get_iowait_time(cpu);
>
> I don't know if I understand it correctly. Looking forward to your answer.
get_iowait_time(cpu) is terminally broken, see commit:
e33a9bba85a8 ("sched/core: move IO scheduling accounting from io_schedule_timeout() into scheduler")
next prev parent reply other threads:[~2019-08-21 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 7:12 [PATCH] cpustat: print watchdog time and statistics of soft and hard interrupts in soft lockup scenes c00423981
2019-08-20 11:04 ` Peter Zijlstra
2019-08-21 8:26 ` c00423981
2019-08-21 10:46 ` Peter Zijlstra [this message]
2019-08-22 11:58 ` [PATCH V2] " c00423981
2019-08-22 16:14 ` Peter Zijlstra
2019-08-23 7:26 ` c00423981
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821104643.GA2349@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=caomeng5@huawei.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox