From: Mark Brown <broonie@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Li Yang <leoyang.li@nxp.com>,
nandor.han@vaisala.com, Biwen Li <biwen.li@nxp.com>,
a.zummo@towertech.it, linux-rtc@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [v2] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w
Date: Wed, 21 Aug 2019 12:47:22 +0100 [thread overview]
Message-ID: <20190821114722.GF5128@sirena.co.uk> (raw)
In-Reply-To: <20190821113856.GB27031@piout.net>
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
On Wed, Aug 21, 2019 at 01:38:56PM +0200, Alexandre Belloni wrote:
> On 21/08/2019 12:30:29+0100, Mark Brown wrote:
> > What's the mechanism here? It's a very strange thing to require.
> The clock control is on the first register, then you have sec, min,
> hour, day, mon, year.
> To be able to set the clock accurately, you need to first disable the
> clock, then set the time and date and finally reenable the clock in the
> first register. This should be done in a single i2c write.
Ugh, right. And of course it would be silly to put the enable register
last or done some sort of strobe thing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-21 11:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 2:46 [v2] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w Biwen Li
2019-08-16 8:04 ` Alexandre Belloni
2019-08-16 15:50 ` Li Yang
2019-08-16 16:28 ` Alexandre Belloni
2019-08-16 19:40 ` Li Yang
2019-08-20 18:22 ` Mark Brown
2019-08-20 18:33 ` Li Yang
2019-08-21 11:21 ` Mark Brown
2019-08-21 11:24 ` Alexandre Belloni
2019-08-21 11:30 ` Mark Brown
2019-08-21 11:38 ` Alexandre Belloni
2019-08-21 11:47 ` Mark Brown [this message]
2019-08-21 6:20 ` Nandor Han
2019-08-26 4:29 ` [EXT] " Biwen Li
2019-08-26 9:17 ` Nandor Han
2019-08-26 9:49 ` Biwen Li
2019-08-26 10:06 ` Alexandre Belloni
2019-08-26 10:40 ` Biwen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821114722.GF5128@sirena.co.uk \
--to=broonie@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biwen.li@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=nandor.han@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox