Re: [patch 03/44] posix-timer: Use a callback for cancel synchronization

Thomas Gleixner
2019-08-20T13:08:39Z

On Mon, 19 Aug 2019, Christoph Hellwig wrote:

> > + if (!WARN_ON_ONCE(kc->timer_wait_running))
> > + kc->timer_wait_running(timer);
>
> This looks weird. The only place calling yor new method only does so
> after checking that it is not set and actually warns if it set?

Yeah, that wants to be;

if (!WARN_ON_ONCE(!kc->timer_wait_running))
kc->timer_wait_running(timer);