From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: josh@joshtriplett.org, rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: don't include <linux/ktime.h> in rcutiny.h
Date: Wed, 21 Aug 2019 20:02:00 -0700 [thread overview]
Message-ID: <20190822030200.GX28441@linux.ibm.com> (raw)
In-Reply-To: <20190822015343.4058-1-hch@lst.de>
On Thu, Aug 22, 2019 at 10:53:43AM +0900, Christoph Hellwig wrote:
> The kbuild reported a built failure due to a header loop when RCUTINY is
> enabled with my pending riscv-nommu port. Switch rcutiny.h to only
> include the minimal required header to get HZ instead.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Queued for review and testing, thank you!
Do you need this in v5.4? My normal workflow would put it into v5.5.
Thanx, Paul
> ---
> include/linux/rcutiny.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rcutiny.h b/include/linux/rcutiny.h
> index 8e727f57d814..9bf1dfe7781f 100644
> --- a/include/linux/rcutiny.h
> +++ b/include/linux/rcutiny.h
> @@ -12,7 +12,7 @@
> #ifndef __LINUX_TINY_H
> #define __LINUX_TINY_H
>
> -#include <linux/ktime.h>
> +#include <asm/param.h> /* for HZ */
>
> /* Never flag non-existent other CPUs! */
> static inline bool rcu_eqs_special_set(int cpu) { return false; }
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-08-22 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 1:53 [PATCH] rcu: don't include <linux/ktime.h> in rcutiny.h Christoph Hellwig
2019-08-22 3:02 ` Paul E. McKenney [this message]
2019-08-22 3:48 ` Christoph Hellwig
2019-08-22 14:00 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822030200.GX28441@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=hch@lst.de \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox