From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57677C3A59D for ; Thu, 22 Aug 2019 08:50:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24DDE205C9 for ; Thu, 22 Aug 2019 08:50:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="iSiNnufs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731728AbfHVIug (ORCPT ); Thu, 22 Aug 2019 04:50:36 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:36772 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730488AbfHVIug (ORCPT ); Thu, 22 Aug 2019 04:50:36 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7M8nQqm124526; Thu, 22 Aug 2019 08:50:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=lApRD2BRq+7hJJnluRFUtj3dNodqui2pOpL9TsZdsvQ=; b=iSiNnufs8VT/Fp6eeTleeLVU8AU9c4CqoxJehp52aW8SCgldaYQEv3hRjXlp3sib6Bv8 +I8QdH45Ej0gWl/KtOdi5C6VBfmseZWUmuEVsWLIxjbrKPdWO+kic2yP2LcSVxURHZi6 olxLndkXNmG9qo76vKM8saAj9DpSMdW94krPu+cvawH/rqCol75autCPPATW7dGah6CM dHJvSAYjZOkBX0L9z8YJ0zaNl2eoR7kHKivMywZIDorRa/emJ4Lv+t3ltxq9wiR7O7HN 11fGb/PJO7mtrj784NFwD6spzxe8XNuCF1PnzxXBWV8/luhvx/N/0hRGa/TKu+pqwbPP Uw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2uea7r3x7s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Aug 2019 08:50:17 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7M8nHSC081461; Thu, 22 Aug 2019 08:50:17 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2uh83prxbk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Aug 2019 08:50:17 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7M8oGGJ026765; Thu, 22 Aug 2019 08:50:16 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 22 Aug 2019 01:50:15 -0700 Date: Thu, 22 Aug 2019 11:50:08 +0300 From: Dan Carpenter To: Colin King Cc: Greg Kroah-Hartman , John Whitmore , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192u: remove redundant assignment to pointer crypt Message-ID: <20190822085008.GH4451@kadam> References: <20190822084609.8971-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190822084609.8971-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9355 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908220097 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9355 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908220097 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 22, 2019 at 09:46:09AM +0100, Colin King wrote: > From: Colin Ian King > > The pointer crypt is being set with a value that is never read, > the assignment is redundant and hence can be removed. > > Thanks to Dan Carpenter for sanity checking that this was indeed > redundant. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter