public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
	Nageswara R Sastry <nasastry@in.ibm.com>
Subject: Re: [PATCH] perf c2c: Fix report with offline cpus
Date: Thu, 22 Aug 2019 12:10:26 +0200	[thread overview]
Message-ID: <20190822101026.GE28439@krava> (raw)
In-Reply-To: <20190822085045.25108-1-ravi.bangoria@linux.ibm.com>

On Thu, Aug 22, 2019 at 02:20:45PM +0530, Ravi Bangoria wrote:
> If c2c is recorded on a machine where any cpus are offline,
> 'perf c2c report' throws an error "node/cpu topology bugFailed
> setup nodes". It fails because while preparing node-cpu mapping
> we don't consider offline cpus.
> 
> Fixes: 1e181b92a2da ("perf c2c report: Add 'node' sort key")
> Reported-by: Nageswara R Sastry <nasastry@in.ibm.com>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

> ---
>  tools/perf/builtin-c2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 9e6cc86..fc68a94 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -2027,7 +2027,7 @@ static int setup_nodes(struct perf_session *session)
>  		c2c.node_info = 2;
>  
>  	c2c.nodes_cnt = session->header.env.nr_numa_nodes;
> -	c2c.cpus_cnt  = session->header.env.nr_cpus_online;
> +	c2c.cpus_cnt  = session->header.env.nr_cpus_avail;
>  
>  	n = session->header.env.numa_nodes;
>  	if (!n)
> -- 
> 1.8.3.1
> 

  reply	other threads:[~2019-08-22 10:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22  8:50 [PATCH] perf c2c: Fix report with offline cpus Ravi Bangoria
2019-08-22 10:10 ` Jiri Olsa [this message]
2019-08-22 15:19   ` Arnaldo Carvalho de Melo
2019-08-23 12:29 ` [tip: perf/core] " tip-bot2 for Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822101026.GE28439@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nasastry@in.ibm.com \
    --cc=ravi.bangoria@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox