From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5B15C3A5A1 for ; Thu, 22 Aug 2019 17:28:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADE7B206DD for ; Thu, 22 Aug 2019 17:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494893; bh=rC0zqd/Pa/S7+DOCJZLzaOR/jw40gKJ1bDUaQK1c0Sg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MobxMZoSkU5h2fjtyqSJe9Ku/ivZCgMdwE6C3QiGNuVQMVXMnJc2cMJl91vvAzQ0i PWWvgCunuNAag6EuhYPoCKn5r0IFuHOXlPeqCuy/KQbW6haJyygn8ODCJcZ0d3GYGQ CPzx50Wv+FFdKLl8Nr8suIlsvLRYMAF1O2Xcp0+0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404865AbfHVR1r (ORCPT ); Thu, 22 Aug 2019 13:27:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:51376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404664AbfHVR0N (ORCPT ); Thu, 22 Aug 2019 13:26:13 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A2E12341C; Thu, 22 Aug 2019 17:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494773; bh=rC0zqd/Pa/S7+DOCJZLzaOR/jw40gKJ1bDUaQK1c0Sg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ICjFLMrTWS37iJZ/W8t3W8jOvMWJpVb+80ifKi5Nw2DRPi4nP7njKWWXp/Y06Bk6L XyaHS4JmVHRPwt73qYEVDCcH0iYECOtJW+Bfflg+RTwUMPFaqF/StO6mzsqRQEJUtu +0p7ANaGIH1B8A25gUayJujeylZwS6CrN2dIuOdM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , zhengbin , Marcelo Ricardo Leitner , Neil Horman , Jakub Kicinski Subject: [PATCH 4.19 78/85] sctp: fix memleak in sctp_send_reset_streams Date: Thu, 22 Aug 2019 10:19:51 -0700 Message-Id: <20190822171734.481850470@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171731.012687054@linuxfoundation.org> References: <20190822171731.012687054@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhengbin [ Upstream commit 6d5afe20397b478192ed8c38ec0ee10fa3aec649 ] If the stream outq is not empty, need to kfree nstr_list. Fixes: d570a59c5b5f ("sctp: only allow the out stream reset when the stream outq is empty") Reported-by: Hulk Robot Signed-off-by: zhengbin Acked-by: Marcelo Ricardo Leitner Acked-by: Neil Horman Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/sctp/stream.c | 1 + 1 file changed, 1 insertion(+) --- a/net/sctp/stream.c +++ b/net/sctp/stream.c @@ -416,6 +416,7 @@ int sctp_send_reset_streams(struct sctp_ nstr_list[i] = htons(str_list[i]); if (out && !sctp_stream_outq_is_empty(stream, str_nums, nstr_list)) { + kfree(nstr_list); retval = -EAGAIN; goto out; }